Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4627_felwood_mineral_rework #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

4627_felwood_mineral_rework #325

wants to merge 1 commit into from

Commits on Jul 2, 2024

  1. 4627_felwood_mineral_rework 

    Complete overhaul of the mineral node data in Felwood, based on the type and location data available on Wowhead, for example:
https://www.wowhead.com/classic/object=176645/mithril-deposit

Removes the few existing gameobjects already in Felwood (there were only 6) and their pool_gameobject entries.

Based on the feedback I got from my earlier pull request I built everything using the spawn_group tables, including spawn_group_entry to minimize the number of gameobject entries added.

I decieded to address a zone like Felwood first to see what you think, especially because there's basically no existing data to mess up/conflict with. I also tried to structure the insert statements based on examples that were sent to me. Other zones are more of a mixed bag of newer spawn_group data and older pool data.

This may not be perfectly sniffed data, but imo its a big leap in the right direction at least.

The original pull request and the discussion had on it can be found here if interested, finally got around to looking into this again:
cmangos#309
    @Sneakyabc
    Sneakyabc committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    04fc6cc View commit details
    Browse the repository at this point in the history