Fix build system scripts (closes #2723)

[DRSDavidSoft]

Description

This PR updates some build properties in order to fix both the AppVeyor builds and also the build scripts running on a local machine.

I plan to work on a GitHub Actions PR in order to either replace AppVeyor or run GitHub Actions alongside it.

Note

Please first merge the following PRs, as this one contains commits from those as well:

• Use TaskDialog instead of MessageBox (Fixes Builds) #2746
• Add bin\cmder_shell.cmd #2747

Status

Closes #2723

Thanks! 😄

[daxgames]

@DRSDavidSoft Thanks and merged.

[daxgames]

@DRSDavidSoft build is still failing. although it worked fine for me on my local system.

@MartiUK any changes required for the appveyor job that I think you own to make these changes work to fix the build scripts.

[daxgames]

@DRSDavidSoft ???
@MartiUK ???

[DRSDavidSoft]

@daxgames I think it's time to add me as the cmder core dev teams. I'd like to ask for the same permissions as a maintainer, and also to the AppVeyor CI dashboard. I'll fix everything as needed in order to make the build system functional again.

Also, please give me permissions so I can set up GitHub actions, and also update issues templates.

Other than that, the build system is working on my forks:
https://ci.appveyor.com/project/DRSDavidSoft/cmder

[daxgames]

@DRSDavidSoft I don't even have access to the appveyor stuff that is why I asked @MartiUK about it.

While I am currently the most active here I don't know if it is my call to give the access you request. If the rest of the @cmderdev/trusted-contributors agree I am all for it.

@MartiUK is currently working on github actions but he may be willing to turn it over to you.

[MartiUK]

@DRSDavidSoft Apologies, I thought you already were a trusted contributor. I've invited you, you're welcome to continue on with the changes to appveyor etc.

[DRSDavidSoft]

@MartiUK Thanks for granting the permission, I already created the GitHub Actions workflow for building Cmder (more in #2725 (comment)). However, there is still an issue with AppVeyor:

I have yet again limited functionality to apply adjustments to the repo's CI settings (beside GitHub actions), and I don't have access to the AppVeyor settings (in the MartiUK account):

❌ https://ci.appveyor.com/project/MartiUK/cmder

✔️ https://ci.appveyor.com/project/DRSDavidSoft/cmder

For reference, the same appveyor.yml config file and the same repo builds correctly on my AppVeyor instance:

I would appreciate it if you could either grant me access to your fork of Cmder on AppVeyor, or change Environment → Build worker image to Visual Studio 2019, or allow me to use appveyor.com/project/DRSDavidSoft instead of appveyor.com/project/MartiUK in the cmder repo.

This will require adding back the AppVeyor marketplace app to the GitHub repo, which I'd appreciate if either you could do it, or grant me the required permissions in order for me to install it.

Thanks! 👍🏻

[DRSDavidSoft]

@MartiUK I would also appreciate it if you could send an screenshot of the following settings in your AppVeyor panel:

[daxgames]

It would be great if we all had access tonthe Appveyor stuff if possible.

[DRSDavidSoft]

@daxgames There is documentation regarding how to set up an organization with proper access to team mebers:
https://www.appveyor.com/docs/team-setup/

[DRSDavidSoft]

Tracking in #2734

[MartiUK]

I've enabled team access to appveyor, hopefully you guys can just login with github on appveyor and you'll have access

[MartiUK]

@MartiUK I would also appreciate it if you could send an screenshot of the following settings in your AppVeyor panel:

They are exactly as you have them there

[MartiUK]

@MartiUK Thanks for granting the permission, I already created the GitHub Actions workflow for building Cmder (more in #2725 (comment)). However, there is still an issue with AppVeyor:

I have yet again limited functionality to apply adjustments to the repo's CI settings (beside GitHub actions), and I don't have access to the AppVeyor settings (in the MartiUK account):

https://ci.appveyor.com/project/MartiUK/cmder

https://ci.appveyor.com/project/DRSDavidSoft/cmder

For reference, the same appveyor.yml config file and the same repo builds correctly on my AppVeyor instance:

I would appreciate it if you could either grant me access to your fork of Cmder on AppVeyor, or change Environment → Build worker image to Visual Studio 2019, or allow me to use appveyor.com/project/DRSDavidSoft instead of appveyor.com/project/MartiUK in the cmder repo.

This will require adding back the AppVeyor marketplace app to the GitHub repo, which I'd appreciate if either you could do it, or grant me the required permissions in order for me to install it.

Thanks! 👍🏻

Set worker image to VS 2019

[DRSDavidSoft]

Unfortunately, now no one can access the project (signed-in or signed-out):
https://ci.appveyor.com/project/MartiUK/cmder

[MartiUK]

It has been renamed to: https://ci.appveyor.com/project/cmderdev/cmder