Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github Actions to build and release #2725

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Use Github Actions to build and release #2725

merged 5 commits into from
Oct 14, 2022

Conversation

MartiUK
Copy link
Member

@MartiUK MartiUK commented Jul 18, 2022

Fixes #2723
Fixes #2729

@daxgames
Copy link
Member

Did Appveyor discontinue some part of their service offering that broke this?

@MartiUK
Copy link
Member Author

MartiUK commented Jul 18, 2022

Looking into it but yeah it's likely they don't install the older platform tools now

@Stanzilla
Copy link
Member

AppVeyor is pretty dead yeah, might be easier if we just switched to GitHub Actions?

@MartiUK
Copy link
Member Author

MartiUK commented Jul 18, 2022

That would be my preference too

@MartiUK MartiUK added the 📌 Pinned Issue will not become stale label Jul 25, 2022
@MartiUK MartiUK added this to the 1.4 milestone Jul 25, 2022
@MartiUK MartiUK changed the title Fix appveyor Visual studio issues Use Github Actions to build and release Jul 25, 2022
@daxgames
Copy link
Member

daxgames commented Sep 1, 2022

@MartiUK @Stanzilla Hey guys do either of you know the secret sauce to be able to compile the launcher locally on Windows running VS Community(any version).

I have never been able to use `scripts\build.ps1:

image

I figured out on an old windows install with VS Community 2017 but I am getting the below when I try now with Visual Studio Community 2022:

image

Asking here because I hope you guys can save me time of digging to figure it out again.

@Stanzilla
Copy link
Member

I haven't done that in ages but your first error message looks like you are missing or having a wrong version of the Windows SDK?

Also I faintly remember that I did not use build.ps1 but just hit compile in VS

@daxgames
Copy link
Member

daxgames commented Sep 1, 2022

@Stanzilla I actially found my old laptop that has vs community 2019 on it and both script and gui work fine.

No such luck with vs community 2022 even though it appears I have all SDK installed correctly. Probably missing one small piece.

Thanks for the reply.

@daxgames
Copy link
Member

daxgames commented Sep 4, 2022

@Stanzilla I figured out how to get it to build on VS Comunity 2022.

I had to change the platform tools in the UI to something then change them back to the original. This allows it to build in the UI.

Then for scripts/build.ps1 to work I had to open the x64 Native Tools Command Prompt for VS 2022 Start Menu shortcut, run powershell, then run scripts/build.ps1 -compile .

Initially I was launching the Developer PowerShell for VS 2022 Start menu shortcut and running scripts/build.ps1 -compile which failed with the windows.h not found error.

I am obviously not a proficient Visual Studio user! 👍

@MartiUK
Copy link
Member Author

MartiUK commented Sep 6, 2022

I've been busy with work recently but I was working on the build scripts as well to work with the latest Windows SDK, but thanks @daxgames

@DRSDavidSoft DRSDavidSoft merged commit 6cd7817 into master Oct 14, 2022
@DRSDavidSoft
Copy link
Contributor

@MartiUK I added an initial GitHub Actions workflow to build Cmder using GitHub, however there are some known limitations regarding artifacts (e.g. it seems that zipped artificats) are doubly created, i.e. once by Cmder build scripts and one more time by GitHub actions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 Pinned Issue will not become stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MSI Package Cmder build is failing
4 participants