-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github Actions to build and release #2725
Conversation
Did Appveyor discontinue some part of their service offering that broke this? |
Looking into it but yeah it's likely they don't install the older platform tools now |
AppVeyor is pretty dead yeah, might be easier if we just switched to GitHub Actions? |
That would be my preference too |
@MartiUK @Stanzilla Hey guys do either of you know the secret sauce to be able to compile the launcher locally on Windows running VS Community(any version). I have never been able to use `scripts\build.ps1: I figured out on an old windows install with VS Community 2017 but I am getting the below when I try now with Visual Studio Community 2022: Asking here because I hope you guys can save me time of digging to figure it out again. |
I haven't done that in ages but your first error message looks like you are missing or having a wrong version of the Windows SDK? Also I faintly remember that I did not use build.ps1 but just hit compile in VS |
@Stanzilla I actially found my old laptop that has vs community 2019 on it and both script and gui work fine. No such luck with vs community 2022 even though it appears I have all SDK installed correctly. Probably missing one small piece. Thanks for the reply. |
@Stanzilla I figured out how to get it to build on VS Comunity 2022. I had to change the platform tools in the UI to something then change them back to the original. This allows it to build in the UI. Then for Initially I was launching the I am obviously not a proficient Visual Studio user! 👍 |
I've been busy with work recently but I was working on the build scripts as well to work with the latest Windows SDK, but thanks @daxgames |
@MartiUK I added an initial GitHub Actions workflow to build Cmder using GitHub, however there are some known limitations regarding artifacts (e.g. it seems that zipped artificats) are doubly created, i.e. once by Cmder build scripts and one more time by GitHub actions) |
Fixes #2723
Fixes #2729