Remove appveyor config

[MartiUK]

We can create releases and upload build artefacts without the need of AppVeyor. I think we should switch it off.

This should be merged after #2804

Signed-off-by: Martin Kemp me@martinke.mp

[DRSDavidSoft]

@MartiUK One problem was present when I was initially added the GH actions task:
#2725 (comment)

Without AppVeyor, all builds it seems will contain a ZIP file that contains another ZIP file in it

--

Update: It appears action-gh-release might not have this issue, however, the unreleased builds will still suffer from this issue.

IMHO, there isn't any harm in multiple CIs building the same project, but I also support moving entirely to GH actions for the sake of simiplicity.

[MartiUK]

Unfortunately, nothing we can do about the double zipping of artefacts, perhaps it'll be better to upload to something like s3?

I'm happy to pay for Cloudflare r2, as the cmder.app domain is under Cloudflare at the moment. It means we can include a pre-release build on the site as well.

[DRSDavidSoft]

Ah, I wish we kept AppVeyor for now, GitHub actions is still building double ZIP files #2725 (comment)) - try downloading artifcats from here:
https://github.com/cmderdev/cmder/actions/runs/5611280395

Maybe this issue has been solved since I initially implemented GitHub actions, but I haven't had time to investigate or rewrite the action scripts. Would you vote to still remove AppVeyor if the issue with GH actions is still present?

[Stanzilla]

Ah, I wish we kept AppVeyor for now, GitHub actions is still building double ZIP files #2725 (comment)) - try downloading artifcats from here: cmderdev/cmder/actions/runs/5611280395

Maybe this issue has been solved since I initially implemented GitHub actions, but I haven't had time to investigate or rewrite the action scripts. Would you vote to still remove AppVeyor if the issue with GH actions is still present?

Nah, they still think that is working as intended

[DRSDavidSoft]

Hey @Stanzilla long time no see! Sorry, do you mean they as GitHub or @MartiUK?

Can I also have everyone's opinion on what should the CI prepare for our users? Personally, I am against double compression. It doesn't make sense to me for the CI to give users a ZIP file that contains a 7Z file inside it. I couldn't figure out a way to bypass this back when I implemented GitHub actions.

Options:

• Leave it as is, forgo AppVeyor
• Remove 7Z files (I'm against this as well personally)
• Bring back AppVeyor (or any other CI that provides raw 7Z file as is)
• Investigate GitHub actions to fix this issue

[Stanzilla]

They as in Github. I just default to GH actions for everything now because every other service is shady or costs money. the double zipping is annoying as well but less so than other stuff, imo.

[MartiUK]

As I said earlier I'm happy to throw some cash in to upload our archives into Cloudflare R2 for the website and our GH releases to link to, to avoid the double zipping issue.

[DRSDavidSoft]

@MartiUK Thanks, we just need to somehow implement it. I'm busy at the moment, but if you have any links to a documentation please share so I can take a look and see if I can implement it. Hopefully it's easy to do.