This repository has been archived by the owner on Aug 28, 2022. It is now read-only.
chore: update rollup/deps and deno version in ci test #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @buttercubz 👋 Thanks for the contribution! Been on hols without laptop so not been able to whip round and get the latest versions updated in all my modules 😅 thanks for doing some of the chore work! I run a |
cmorten
reviewed
May 30, 2021
src/rollup/rollup.ts
Outdated
| @@ -44,7 +44,8 @@ export async function rollup( | |||
| }; | |||
|
|
|||
| try { | |||
| const bundle = await _rollup(options); | |||
| // deno-lint-ignore no-explicit-any | |||
| const bundle = await _rollup(options as any); | |||
There was a problem hiding this comment.
Guessing seeing a type mismatch? Check out some of the extended types around https://github.com/cmorten/deno-rollup/blob/main/src/rollup/mod.ts#L165, suspect may have to add the new sanitizeFileName or sim. somewhere, shouldn’t need to cast as any.
There was a problem hiding this comment.
i found the problem, now this is fixed
|
Superseded by #34 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.