Skip to content
This repository was archived by the owner on Aug 28, 2022. It is now read-only.

chore: update rollup/deps and deno version in ci test #33

Closed
wants to merge 3 commits into from
Closed

chore: update rollup/deps and deno version in ci test #33

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e04b37a
chore: update rollup/deps and deno ci version
buttercubz May 29, 2021
c7e0460
chore: update deno version on ci test
buttercubz May 29, 2021
97b8ab0
fix: mismatched types
buttercubz May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
deno-version: [1.8.2]
deno-version: [1.10.2]

runs-on: ${{ matrix.os }}

Expand All @@ -25,7 +25,7 @@ jobs:
strategy:
matrix:
os: [windows-latest]
deno-version: [1.8.2]
deno-version: [1.10.2]

runs-on: ${{ matrix.os }}

Expand Down
14 changes: 7 additions & 7 deletions deps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* std
*/

export {
export {
basename,
dirname,
extname,
Expand All @@ -14,26 +14,26 @@ export {
resolve,
sep,
toFileUrl,
} from "https://deno.land/std@0.91.0/path/mod.ts";
} from "https://deno.land/std@0.97.0/path/mod.ts";
export {
bold,
cyan,
dim,
green,
red,
underline,
} from "https://deno.land/std@0.91.0/fmt/colors.ts";
export { EventEmitter } from "https://deno.land/std@0.91.0/node/events.ts";
} from "https://deno.land/std@0.97.0/fmt/colors.ts";
export { EventEmitter } from "https://deno.land/std@0.97.0/node/events.ts";

/**
* Rollup
*/

// @deno-types="https://unpkg.com/rollup@2.42.3/dist/rollup.d.ts"
// @deno-types="https://unpkg.com/rollup@2.50.4/dist/rollup.d.ts"
export {
rollup,
VERSION,
} from "https://unpkg.com/rollup@2.42.3/dist/es/rollup.browser.js";
} from "https://unpkg.com/rollup@2.50.4/dist/es/rollup.browser.js";
export type {
AddonHook,
AddonHookFunction,
Expand Down Expand Up @@ -131,7 +131,7 @@ export type {
WarningHandler,
WarningHandlerWithDefault,
WatchChangeHook,
} from "https://unpkg.com/rollup@2.42.3/dist/rollup.d.ts";
} from "https://unpkg.com/rollup@2.50.4/dist/rollup.d.ts";

/**
* deno.land/x
Expand Down
1 change: 1 addition & 0 deletions src/mergeOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ function mergeOutputOptions(
preferConst: getOption("preferConst"),
preserveModules: getOption("preserveModules"),
preserveModulesRoot: getOption("preserveModulesRoot"),
sanitizeFileName: getOption("sanitizeFileName"),
sourcemap: getOption("sourcemap"),
sourcemapExcludeSources: getOption("sourcemapExcludeSources"),
sourcemapFile: getOption("sourcemapFile"),
Expand Down
3 changes: 2 additions & 1 deletion src/rollup/rollup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ export async function rollup(
};

try {
const bundle = await _rollup(options);
// deno-lint-ignore no-explicit-any
const bundle = await _rollup(options as any);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing seeing a type mismatch? Check out some of the extended types around https://github.com/cmorten/deno-rollup/blob/main/src/rollup/mod.ts#L165, suspect may have to add the new sanitizeFileName or sim. somewhere, shouldn’t need to cast as any.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found the problem, now this is fixed


return new Proxy(bundle, {
get: (target, prop, receiver) => {
Expand Down
4 changes: 2 additions & 2 deletions test/deps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export * as posixPath from "https://deno.land/std@0.91.0/path/posix.ts";
export { createRequire } from "https://deno.land/std@0.91.0/node/module.ts";
export * as posixPath from "https://deno.land/std@0.97.0/path/posix.ts";
export { createRequire } from "https://deno.land/std@0.97.0/node/module.ts";
export { expect } from "https://deno.land/x/expect@v0.2.6/mod.ts";
export { default as assert } from "https://esm.sh/assert@2.0.0";
export { default as listGitHub } from "https://esm.sh/list-github-dir-content@3.0.0";
Expand Down
2 changes: 1 addition & 1 deletion version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { VERSION } from "./mod.ts";

export const coreRollupVersion = VERSION;
export const denoRollupVersion = "0.17.1";
export const denoRollupVersion = "0.18.0";
export const version = `${coreRollupVersion}+${denoRollupVersion}`;