Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBouputService migration #28

Closed
17 tasks done
francescobrivio opened this issue Sep 15, 2021 · 15 comments
Closed
17 tasks done

DBouputService migration #28

francescobrivio opened this issue Sep 15, 2021 · 15 comments
Assignees
@yuanchao @tvami @mmusich @SanjanaSekhar

Comments

@francescobrivio
Copy link
Contributor

francescobrivio commented Sep 15, 2021 •
edited by tvami
Loading

Original issue: cms-sw/cmssw#28699

In cms-sw/cmssw#35048 some methods in CondCore/DBOutputService were changed to accept pointers instead of references.

All calls to the following methods should migrated before the old methods (that still accept references and were left in the code in order not to break the release) can be removed:

  • writeForNextLumisection
  • writeOne
  • writeMany
  • createNewIOV

The PR cms-sw/cmssw#35556 then renames the new method

gDoc for the files: https://docs.google.com/spreadsheets/d/1DJ6u45mBXW0bfYcdNNzauIT9nlWlyyjWZhKPuOmpB7U/edit#gid=1265504621

To do list:

  • Prepare a list of all packages to be migrated
  • Migrate the packages
  • BeamSpot
  • SiPixel
  • SiStrips
  • TkAlignment
  • ECAL
  • HCAL
  • DT
  • CSC
  • RPC
  • Geometry
  • JetMet
  • Btagging
  • AlCa
  • DB
  • Remove old methods that still accept references
@francescobrivio francescobrivio changed the title **DBouputService migration** DBouputService migration Sep 15, 2021
@yuanchao
Copy link

yuanchao commented Sep 22, 2021 •
edited
Loading

To check which packages are still using the deprecated call with pointers instead of reference. Here are those call to writeOne:

  • Alignment/CommonAlignmentAlgorithm/plugins/SiPixelLorentzAngleCalibration.cc
  • Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc
  • Alignment/CommonAlignmentAlgorithm/plugins/SiStripLorentzAngleCalibration.cc
  • Alignment/CommonAlignmentAlgorithm/src/AlignmentParametersIO.cc
  • Alignment/CommonAlignmentAlgorithm/src/AlignmentParametersIORoot.cc
  • Alignment/CommonAlignmentAlgorithm/src/AlignmentUserVariablesIO.cc
  • Alignment/CommonAlignmentProducer/plugins/GlobalTrackerMuonAlignment.cc
  • Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
  • Alignment/HIPAlignmentAlgorithm/src/HIPUserVariablesIORoot.cc
  • Alignment/LaserAlignment/plugins/LaserAlignment.cc
  • Alignment/MillePedeAlignmentAlgorithm/src/MillePedeVariablesIORoot.cc
  • Alignment/MuonAlignment/plugins/MuonMisalignedProducer.cc
  • Alignment/MuonAlignment/src/MuonAlignment.cc
  • Alignment/OfflineValidation/plugins/TrackerGeometryCompare.cc
  • Alignment/SurveyAnalysis/plugins/SurveyDBUploader.cc
  • Alignment/SurveyAnalysis/plugins/SurveyInputTrackerFromDB.cc
  • Alignment/TrackerAlignment/plugins/CreateTrackerAlignmentRcds.cc
  • Alignment/TrackerAlignment/plugins/MCMisalignmentScaler.cc
  • Alignment/TrackerAlignment/plugins/MisalignedTrackerESProducer.cc
  • Alignment/TrackerAlignment/plugins/TrackerSystematicMisalignments.cc
  • Alignment/TrackerAlignment/src/TrackerAlignment.cc
  • CalibCalorimetry/EcalTrivialCondModules/src/EcalLaserCondTools.cc
  • CalibPPS/TimingCalibration/plugins/PPSDiamondSampicTimingCalibrationPCLHarvester.cc
  • CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLHarvester.cc
  • CalibTracker/SiPixelQuality/plugins/SiPixelStatusHarvester.cc
  • CalibTracker/SiStripChannelGain/src/SiStripGainsPCLHarvester.cc
  • CalibTracker/SiStripQuality/plugins/SiStripBadStripFromQualityDBWriter.cc
  • Calibration/EcalCalibAlgos/src/ECALpedestalPCLHarvester.cc
  • Calibration/LumiAlCaRecoProducers/plugins/CorrPCCProducer.cc
  • Calibration/TkAlCaRecoProducers/plugins/AlcaBeamSpotHarvester.cc
  • CommonTools/MVAUtils/plugins/GBRForestWriter.cc
  • CondCore/DBOutputService/test/stubs/IOVPayloadAnalyzer.cc
  • CondCore/DBOutputService/test/stubs/IOVPayloadEndOfJob.cc
  • CondCore/DBOutputService/test/stubs/MyDataAnalyzer.cc
  • CondCore/DBOutputService/test/stubs/Timestamp.cc
  • CondCore/DBOutputService/test/stubs/writeBlob.cc
  • CondCore/DBOutputService/test/stubs/writeBlobComplex.cc
  • CondCore/DBOutputService/test/stubs/writeInt.cc
  • CondCore/DBOutputService/test/stubs/writeKeyed.cc
  • CondCore/DBOutputService/test/stubs/writeMultipleRecords.cc
  • CondFormats/Common/test/ProduceDropBoxMetadata.cc
  • CondFormats/EcalObjects/test/stubs/EcalTimeBiasCorrectionsFillInitial.cc
  • CondFormats/MFObjects/test/MagFieldConfigDBWriter.cc
  • CondFormats/PCLConfig/plugins/AlignPCLThresholdsWriter.cc
  • CondFormats/PhysicsToolsObjects/test/TFormulaWriter.cc
  • CondFormats/PhysicsToolsObjects/test/TGraphWriter.cc
  • CondFormats/RecoMuonObjects/test/ProduceAgingObject.cc
  • CondFormats/SiPixelObjects/test/FastSiPixelFEDChannelContainerFromQuality.cc
  • CondFormats/SiPixelObjects/test/SiPixelFEDChannelContainerFromQualityConverter.cc
  • CondFormats/SiPixelObjects/test/SiPixelFEDChannelContainerWriteFromASCII.cc
  • CondFormats/SiPixelObjects/test/SiPixelQualityProbabilitiesTestWriter.cc
  • CondFormats/SiPixelObjects/test/SiPixelQualityProbabilitiesWriteFromASCII.cc
  • CondTools/CTPPS/plugins/PPSTimingCalibrationWriter.cc
  • CondTools/CTPPS/plugins/WriteCTPPSBeamParameters.cc
  • CondTools/CTPPS/plugins/WritePPSAlignmentConfig.cc
  • CondTools/CTPPS/plugins/WritePPSAlignmentConfiguration.cc
  • CondTools/CTPPS/plugins/WritePPSAssociationCuts.cc
  • CondTools/CTPPS/src/CTPPSRPAlignmentInfoAnalyzer.cc
  • CondTools/CTPPS/src/WriteCTPPSPixGainCalibrations.cc
  • CondTools/CTPPS/src/WriteCTPPSPixelAnalysisMask.cc
  • CondTools/CTPPS/src/WriteCTPPSPixelDAQMapping.cc
  • CondTools/DT/plugins/DTKeyedConfigDBInit.cc
  • CondTools/DT/src/DTKeyedConfigHandler.cc
  • CondTools/DT/src/DTUserKeyedConfigHandler.cc
  • CondTools/Ecal/plugins/EcalMustacheSCParametersMaker.cc
  • CondTools/Ecal/plugins/EcalSCDynamicDPhiParametersMaker.cc
  • CondTools/Ecal/src/EcalDBCopy.cc
  • CondTools/Ecal/src/EcalLaser_weekly_Handler.cc
  • CondTools/Geometry/plugins/PPSGeometryBuilder.cc
  • CondTools/Hcal/plugins/BufferedBoostIODBWriter.cc
  • CondTools/SiPhase2Tracker/plugins/DTCCablingMapProducer.cc
  • CondTools/SiPhase2Tracker/plugins/DTCCablingMapTestProducer.cc
  • CondTools/SiPhase2Tracker/plugins/SiPhase2OuterTrackerLorentzAngleWriter.cc
  • CondTools/SiPixel/test/SiPixel2DTemplateDBObjectUploader.cc
  • CondTools/SiPixel/test/SiPixelGenErrorDBObjectUploader.cc
  • CondTools/SiPixel/test/SiPixelTemplateDBObjectUploader.cc
  • CondTools/SiStrip/plugins/SiStripApvGainRescaler.cc
  • CondTools/SiStrip/plugins/SiStripChannelGainFromDBMiscalibrator.cc
  • CondTools/SiStrip/plugins/SiStripNoisesFromDBMiscalibrator.cc
  • DQM/EcalMonitorDbModule/plugins/EcalDQMStatusWriter.cc
  • FWCore/ParameterSet/src/ParameterDescription.cc
  • Geometry/CaloEventSetup/test/CaloAlignmentRcdWrite.cc
  • Geometry/EcalAlgo/src/WriteESAlignments.cc
  • IOPool/Output/src/PoolOutputModule.cc
  • IOPool/Output/src/RootOutputFile.cc
  • JetMETCorrections/FFTJetModules/plugins/FFTJetCorrectorDBWriter.cc
  • JetMETCorrections/Modules/plugins/JetResolutionDBWriter.cc
  • L1Trigger/L1TMuonOverlap/plugins/L1TMuonOverlapParamsDBProducer.cc
  • L1TriggerConfig/Utilities/src/L1KeyListWriter.cc
  • L1TriggerConfig/Utilities/src/L1KeyWriter.cc
  • L1TriggerConfig/Utilities/src/L1MenuWriter.cc
  • L1TriggerConfig/Utilities/src/L1TCaloParamsUpdater.cc
  • L1TriggerConfig/Utilities/src/L1TCaloParamsWriter.cc
  • L1TriggerConfig/Utilities/src/L1TGlobalPrescalesVetosWriter.cc
  • L1TriggerConfig/Utilities/src/L1TMuonBarrelParamsWriter.cc
  • L1TriggerConfig/Utilities/src/L1TMuonEndCapForestWriter.cc
  • L1TriggerConfig/Utilities/src/L1TMuonEndCapParamsWriter.cc
  • L1TriggerConfig/Utilities/src/L1TMuonGlobalParamsWriter.cc
  • L1TriggerConfig/Utilities/src/L1TMuonOverlapParamsWriter.cc
  • RecoEgamma/EgammaTools/test/GBRWrapperMaker.cc
  • RecoMuon/GlobalTrackingTools/test/DYTTuner.cc
  • RecoParticleFlow/PFClusterTools/test/ProducePFCalibrationObject.cc
  • SimCalorimetry/EcalSelectiveReadoutProducers/src/EcalSRCondTools.cc
  • SimGeneral/MixingModule/plugins/Mixing2DB.cc

All .cc files calling createNewIOV:

  • Alignment/CocoaFit/src/CocoaDBMgr.cc
  • Alignment/CommonAlignmentProducer/plugins/GlobalTrackerMuonAlignment.cc
  • Alignment/LaserAlignment/plugins/LaserAlignment.cc
  • Alignment/TrackerAlignment/src/TrackerAlignment.cc
  • CalibCalorimetry/CaloMiscalibTools/plugins/WriteEcalMiscalibConstants.cc
  • CalibCalorimetry/CaloMiscalibTools/plugins/WriteEcalMiscalibConstantsMC.cc
  • CalibCalorimetry/EcalTPGTools/plugins/EcalTPGDBCopy.cc
  • Calibration/TkAlCaRecoProducers/plugins/AlcaBeamSpotHarvester.cc
  • CalibTracker/SiPixelConnectivity/test/SiPixelFedCablingMapWriter.cc
  • CalibTracker/SiStripESProducers/plugins/DBWriter/SiStripFedCablingManipulator.cc
  • CalibTracker/SiStripESProducers/plugins/fake/SiStripApvGainBuilderFromTag.cc
  • CalibTracker/SiStripESProducers/plugins/fake/SiStripNoiseNormalizedWithApvGainBuilder.cc
  • CondCore/DBOutputService/src/PoolDBOutputService.cc
  • CondFormats/DTObjects/test/stubs/DTConfigWrite.cc
  • CondFormats/DTObjects/test/stubs/DTDeadUpdate.cc
  • CondFormats/DTObjects/test/stubs/DTDeadWrite.cc
  • CondFormats/DTObjects/test/stubs/DTMapWrite.cc
  • CondFormats/DTObjects/test/stubs/DTRangeT0Write.cc
  • CondFormats/DTObjects/test/stubs/DTT0Write.cc
  • CondFormats/PhysicsToolsObjects/test/SiStripDeDx2DBuilder.cc
  • CondFormats/PhysicsToolsObjects/test/SiStripDeDx3DBuilder.cc
  • CondFormats/PhysicsToolsObjects/test/SiStripDeDxMipBuilder.cc
  • CondFormats/RPCObjects/test/RPCReadOutMapBuilder.cc
  • CondFormats/SiPixelObjects/test/SiPixelFedCablingMapTestWriter.cc
  • CondTools/BTau/plugins/BTagCalibrationDbCreator.cc
  • CondTools/BeamSpot/plugins/BeamSpotOnlineHLTRcdWriter.cc
  • CondTools/BeamSpot/plugins/BeamSpotOnlineLegacyRcdWriter.cc
  • CondTools/Ecal/plugins/StoreESCondition.cc
  • CondTools/Ecal/plugins/StoreEcalCondition.cc
  • CondTools/Ecal/src/ESDBCopy.cc
  • CondTools/Ecal/src/EcalDBCopy.cc
  • CondTools/Ecal/src/EcalPFRecHitThresholdsMaker.cc
  • CondTools/Ecal/src/EcalTestDevDB.cc
  • CondTools/Geometry/plugins/CSCRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/DTRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/GEMRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/HcalParametersDBBuilder.cc
  • CondTools/Geometry/plugins/ME0RecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/PGeometricDetBuilder.cc
  • CondTools/Geometry/plugins/PHGCalParametersDBBuilder.cc
  • CondTools/Geometry/plugins/PTrackerAdditionalParametersPerDetDBBuilder.cc
  • CondTools/Geometry/plugins/PTrackerParametersDBBuilder.cc
  • CondTools/Geometry/plugins/RPCRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/XMLGeometryBuilder.cc
  • CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc
  • CondTools/L1Trigger/src/DataWriter.cc
  • CondTools/L1TriggerExt/src/DataWriterExt.cc
  • CondTools/SiPixel/test/SiPixelCPEGenericErrorParmUploader.cc
  • CondTools/SiPixel/test/SiPixelCalibConfigurationObjectMaker.cc
  • CondTools/SiPixel/test/SiPixelCondObjBuilder.cc
  • CondTools/SiPixel/test/SiPixelCondObjForHLTBuilder.cc
  • CondTools/SiPixel/test/SiPixelCondObjOfflineBuilder.cc
  • CondTools/SiPixel/test/SiPixelDynamicInefficiencyDB.cc
  • CondTools/SiPixel/test/SiPixelGainCalibScaler.cc
  • CondTools/SiPixel/test/SiPixelGainCalibrationReadDQMFile.cc
  • CondTools/SiPixel/test/SiPixelGainCalibrationRejectNoisyAndDead.cc
  • CondTools/SiPixel/test/SiPixelLorentzAngleDB.cc
  • CondTools/SiPixel/test/SiPixelPerformanceSummaryBuilder.cc
  • CondTools/SiPixel/test/SiPixelVCalDB.cc
  • CondTools/SiStrip/plugins/SiStripApvGainBuilder.cc
  • CondTools/SiStrip/plugins/SiStripApvSimulationParametersBuilder.cc
  • CondTools/SiStrip/plugins/SiStripBadChannelBuilder.cc
  • CondTools/SiStrip/plugins/SiStripDetVOffFakeBuilder.cc
  • CondTools/SiStrip/plugins/SiStripFedCablingBuilder.cc
  • CondTools/SiStrip/plugins/SiStripNoisesBuilder.cc
  • CondTools/SiStrip/plugins/SiStripPedestalsBuilder.cc
  • CondTools/SiStrip/plugins/SiStripSummaryBuilder.cc
  • CondTools/SiStrip/plugins/SiStripThresholdBuilder.cc
  • Geometry/DTGeometry/test/DTRecoIdealDBLoader.cc
  • HLTrigger/HLTcore/plugins/HLTPrescaleRecorder.cc
  • IOMC/EventVertexGenerators/src/BeamProfile2DB.cc
  • JetMETCorrections/Modules/plugins/JetCorrectorDBWriter.cc
  • JetMETCorrections/Modules/plugins/METCorrectorDBWriter.cc
  • JetMETCorrections/Modules/plugins/QGLikelihoodDBWriter.cc
  • JetMETCorrections/Modules/plugins/QGLikelihoodSystematicsDBWriter.cc
  • MuonAnalysis/MomentumScaleCalibration/plugins/DBWriter.cc
  • PhysicsTools/MVAComputer/test/testWriteMVAComputerCondDB.cc
  • RecoBTag/PerformanceDB/plugins/PhysicsPerformanceDBWriterFromFile_WPandPayload.cc
  • RecoBTag/PerformanceDB/plugins/PhysicsPerformanceDBWriterFromFile_WPandPayload_IOV.cc
  • RecoBTag/PerformanceDB/plugins/PhysicsPerformanceDBWriterTFormula_fromfile_WPandPL.cc
  • RecoBTag/TrackProbability/test/CalibrationSkeleton.cc
  • RecoBTag/TrackProbability/test/TrackProbabilityXMLtoDB.cc
  • RecoHI/HiCentralityAlgos/plugins/CentralityTableProducer.cc
  • RecoHI/HiJetAlgos/plugins/UETableProducer.cc
  • RecoVertex/BeamSpotProducer/plugins/BeamSpotWrite2DB.cc
  • RecoVertex/BeamSpotProducer/src/BeamFitter.cc

All .cc files calling "writeForNextLumisection":

  • CondCore/DBOutputService/test/stubs/LumiBasedUpdateAnalyzer.cc
  • DQM/BeamMonitor/plugins/BeamMonitor.cc
  • DQM/BeamMonitor/plugins/FakeBeamMonitor.cc

(none for writeMany)

Will check out these packages, remove DB old method and see which fails to build.

@yuanchao
Copy link

yuanchao commented Sep 27, 2021 •
edited
Loading

By checking out the CMSSW_12_1_0_pre3, we have the latest DB code. I comment out the old writeOne API such that those not updated from the deprecated method will fail to build.

I grab the master CMSSW source tarball and copy the DB related packages over and compile. So far the following ones which are still calling the old writeOne method need to be updated:

  • Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
  • Alignment/LaserAlignment/plugins/LaserAlignment.cc
  • Alignment/MuonAlignment/src/MuonAlignment.cc
  • Alignment/OfflineValidation/plugins/TrackerGeometryCompare.cc
  • Alignment/SurveyAnalysis/plugins/SurveyDBUploader.cc
  • Alignment/SurveyAnalysis/plugins/SurveyInputTrackerFromDB.cc
  • Alignment/TrackerAlignment/src/TrackerAlignment.cc
  • CalibMuon/DTCalibration/plugins/DTNoiseCalibration.cc
  • CalibMuon/DTCalibration/plugins/DTTTrigFillWithAverage.cc
  • CalibMuon/DTCalibration/plugins/DTT0CalibrationRMS.cc
  • CalibMuon/DTCalibration/plugins/DTT0Correction.cc
  • CalibMuon/DTCalibration/plugins/DTTTrigCorrection.cc
  • CalibMuon/DTCalibration/plugins/DTTTrigCorrectionFirst.cc
  • CalibMuon/DTCalibration/plugins/DTTTrigOffsetCalibration.cc
  • Calibration/TkAlCaRecoProducers/plugins/AlcaBeamSpotHarvester.cc
  • Calibration/LumiAlCaRecoProducers/plugins/CorrPCCProducer.cc
  • CondFormats/Common/test/ProduceDropBoxMetadata.cc
  • Geometry/EcalAlgo/src/WriteESAlignments.cc
  • Geometry/CaloEventSetup/test/CaloAlignmentRcdWrite.cc
  • JetMETCorrections/Modules/plugins/JetResolutionDBWriter.cc
  • RecoParticleFlow/PFClusterTools/test/ProducePFCalibrationObject.cc
  • SimGeneral/MixingModule/plugins/Mixing2DB.cc

(done)

For .cc files calling old createNewIOV method:

  • Alignment/CocoaFit/src/CocoaDBMgr.cc
  • CalibCalorimetry/EcalTPGTools/plugins/EcalTPGDBCopy.cc
  • CalibTracker/SiStripESProducers/plugins/fake/SiStripApvGainBuilderFromTag.cc
  • CalibTracker/SiPixelConnectivity/test/SiPixelFedCablingMapWriter.cc
  • CondFormats/DTObjects/test/stubs/DTConfigWrite.cc
  • CondFormats/DTObjects/test/stubs/DTDeadUpdate.cc
  • CondFormats/DTObjects/test/stubs/DTDeadWrite.cc
  • CondFormats/DTObjects/test/stubs/DTMapWrite.cc
  • CondFormats/DTObjects/test/stubs/DTRangeT0Write.cc
  • CondFormats/DTObjects/test/stubs/DTT0Write.cc
  • CondFormats/PhysicsToolsObjects/test/SiStripDeDx2DBuilder.cc
  • CondFormats/PhysicsToolsObjects/test/SiStripDeDx3DBuilder.cc
  • CondFormats/PhysicsToolsObjects/test/SiStripDeDxMipBuilder.cc
  • CondFormats/SiPixelObjects/test/SiPixelFedCablingMapTestWriter.cc
  • CondFormats/RPCObjects/test/RPCReadOutMapBuilder.cc
  • CondTools/BTau/plugins/BTagCalibrationDbCreator.cc
  • CondTools/Ecal/src/EcalDBCopy.cc
  • CondTools/Ecal/src/EcalPFRecHitThresholdsMaker.cc
  • CondTools/Ecal/src/EcalTestDevDB.cc
  • CondTools/Geometry/plugins/XMLGeometryBuilder.cc
  • CondTools/Geometry/plugins/calowriters.cc
  • CondTools/Geometry/plugins/PTrackerAdditionalParametersPerDetDBBuilder.cc
  • CondTools/Geometry/plugins/GEMRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/PTrackerParametersDBBuilder.cc
  • CondTools/Geometry/plugins/HcalParametersDBBuilder.cc
  • CondTools/Geometry/plugins/CSCRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/RPCRecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/PGeometricDetBuilder.cc
  • CondTools/Geometry/plugins/ME0RecoIdealDBLoader.cc
  • CondTools/Geometry/plugins/PHGCalParametersDBBuilder.cc
  • CondTools/Geometry/plugins/DTRecoIdealDBLoader.cc
  • CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc
  • CondTools/SiPixel/test/SiPixelVCalDB.cc
  • CondTools/SiPixel/test/SiPixelPerformanceSummaryBuilder.cc
  • CondTools/SiPixel/test/SiPixelGainCalibScaler.cc
  • CondTools/SiPixel/test/SiPixelLorentzAngleDB.cc
  • CondTools/SiPixel/test/SiPixelGainCalibrationRejectNoisyAndDead.cc
  • CondTools/SiPixel/test/SiPixelCPEGenericErrorParmUploader.cc
  • CondTools/SiPixel/test/SiPixelCondObjForHLTBuilder.cc
  • CondTools/SiPixel/test/SiPixelCondObjBuilder.cc
  • CondTools/SiPixel/test/SiPixelCondObjOfflineBuilder.cc
  • CondTools/SiPixel/test/SiPixelDynamicInefficiencyDB.cc
  • CondTools/SiPixel/test/SiPixelCalibConfigurationObjectMaker.cc
  • CondTools/SiStrip/plugins/SiStripApvGainBuilder.cc
  • CondTools/SiStrip/plugins/SiStripPedestalsBuilder.cc
  • CondTools/SiStrip/plugins/SiStripNoisesBuilder.cc
  • CondTools/SiStrip/plugins/SiStripFedCablingBuilder.cc
  • CondTools/SiStrip/plugins/SiStripDetVOffFakeBuilder.cc
  • CondTools/SiStrip/plugins/SiStripSummaryBuilder.cc
  • CondTools/SiStrip/plugins/SiStripThresholdBuilder.cc
  • JetMETCorrections/Modules/plugins/JetCorrectorDBWriter.cc
  • JetMETCorrections/Modules/plugins/METCorrectorDBWriter.cc
  • JetMETCorrections/Modules/plugins/QGLikelihoodSystematicsDBWriter.cc
  • PhysicsTools/MVAComputer/test/testWriteMVAComputerCondDB.cc
  • RecoBTag/PerformanceDB/plugins/PhysicsPerformanceDBWriterFromFile_WPandPayload.cc
  • RecoBTag/PerformanceDB/plugins/PhysicsPerformanceDBWriterTFormula_fromfile_WPandPL.cc
  • RecoBTag/PerformanceDB/plugins/PhysicsPerformanceDBWriterFromFile_WPandPayload_IOV.cc
  • RecoHI/HiCentralityAlgos/plugins/CentralityTableProducer.cc
  • RecoVertex/BeamSpotProducer/src/BeamFitter.cc
  • RecoVertex/BeamSpotProducer/plugins/BeamSpotWrite2DB.cc

(done)

For .cc files calling "writeForNextLumisection":
(no deprecated calls)

@tvami
Copy link
Contributor

tvami commented Oct 12, 2021

There is a partial fix in cms-sw/cmssw#35616

This was referenced Oct 14, 2021
Closed
Closed
@mmusich mmusich mentioned this issue Nov 4, 2021
Merged
@tvami
Copy link
Contributor

tvami commented Nov 6, 2021

First of the subsystem PR done in cms-sw/cmssw#35999 (for SiStrips)

@tvami
Copy link
Contributor

tvami commented Nov 7, 2021

Hi @mmusich I found two more files for Strips
https://github.com/cms-sw/cmssw/blob/master/CalibTracker/SiStripChannelGain/src/SiStripGainsPCLHarvester.cc#L136
https://github.com/cms-sw/cmssw/blob/master/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc#L385
(although one might consider this to be an alignment file)

@mmusich
Copy link
Contributor

mmusich commented Nov 7, 2021 •
edited
Loading

https://github.com/cms-sw/cmssw/blob/master/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc#L385

pertains to alignment

@mmusich
Copy link
Contributor

mmusich commented Nov 7, 2021

While https://github.com/cms-sw/cmssw/blob/master/CalibTracker/SiStripChannelGain/src/SiStripGainsPCLHarvester.cc#L136 is already OK. It uses std::unique_ptr

@tvami
Copy link
Contributor

tvami commented Nov 7, 2021

I made a PR for the SiPixelCPE cms-sw/cmssw#36027 I let the rest to @SanjanaSekhar

This was referenced Nov 7, 2021
Merged
Merged
@tvami
Copy link
Contributor

tvami commented Nov 8, 2021

DropBox metadata (among other things) cms-sw/cmssw#36028

@mmusich mmusich mentioned this issue Nov 8, 2021
Merged
@tvami
Copy link
Contributor

tvami commented Nov 9, 2021

Remaining SiPixel done in cms-sw/cmssw#36040

@mmusich mmusich mentioned this issue Nov 10, 2021
Merged
@francescobrivio francescobrivio mentioned this issue Nov 10, 2021
Merged
@tvami
Copy link
Contributor

tvami commented Nov 10, 2021

ECAL is done in cms-sw/cmssw#36062

@tvami
Copy link
Contributor

tvami commented Nov 10, 2021

Beamspot done in cms-sw/cmssw#36077

@tvami
Copy link
Contributor

tvami commented Nov 10, 2021

TkAlignment done in cms-sw/cmssw#36076

@francescobrivio francescobrivio mentioned this issue Nov 11, 2021
Merged
@tvami tvami mentioned this issue Nov 15, 2021
Merged
@tvami
Copy link
Contributor

tvami commented Nov 15, 2021

AlCa part done in cms-sw/cmssw#36090
DB part done in cms-sw/cmssw#36124

@namapane namapane mentioned this issue Nov 15, 2021
Merged
@francescobrivio francescobrivio mentioned this issue Nov 16, 2021
Merged
@hyunyong hyunyong mentioned this issue Nov 16, 2021
Closed
This was referenced Nov 21, 2021
Merged
Merged
@laurenhay laurenhay mentioned this issue Nov 23, 2021
Merged
@panwarlsweet panwarlsweet mentioned this issue Nov 24, 2021
Merged
This was referenced Nov 30, 2021
Merged
Merged
This was referenced Dec 5, 2021
Merged
Merged
@tvami
Copy link
Contributor

tvami commented Dec 17, 2021

The removal of the old method happened in cms-sw/cmssw#36490 , with this, this migration is completed!

@tvami tvami closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuanchao yuanchao

@tvami tvami

@mmusich mmusich

@SanjanaSekhar SanjanaSekhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yuanchao @tvami @mmusich @francescobrivio @SanjanaSekhar