Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopConSourceHandler leaks memory #28699

Closed
Dr15Jones opened this issue Dec 30, 2019 · 10 comments
Closed

PopConSourceHandler leaks memory #28699

Dr15Jones opened this issue Dec 30, 2019 · 10 comments

Comments

@Dr15Jones
Copy link
Contributor

Classes inheriting from PopConSourceHandler are required to call new in the getNewObjects() method and add those to a protected member container. I could not find anywhere that later deletes the objects placed into that container.

@cmsbuild
Copy link
Contributor

A new Issue was created by @Dr15Jones Chris Jones.

@Dr15Jones, @smuzaffar, @silviodonato, @kpedro88, @davidlange6, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

assign alca, db

@cmsbuild
Copy link
Contributor

New categories assigned: db,alca

@ggovi,@christopheralanwest,@franzoni,@tlampen,@pohsun,@tocheng you have been requested to review this Pull request/Issue and eventually sign? Thanks

@ggovi
Copy link
Contributor

ggovi commented Aug 27, 2021

Sorry for the multi-year latency. Addressed by #35048

@tvami
Copy link
Contributor

tvami commented Sep 1, 2021

+alca

@tvami
Copy link
Contributor

tvami commented Sep 1, 2021

Since #35048 is merged, this issue can be closed

@tvami
Copy link
Contributor

tvami commented Sep 1, 2021

close #28699

@tvami
Copy link
Contributor

tvami commented Sep 1, 2021

close #28699

I don't have the power to close this. @Dr15Jones @qliphy @perrotta

@ggovi
Copy link
Contributor

ggovi commented Sep 1, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants