-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate HLTPrescaleRecorder and AlignPCLThresholdsWriter to new PoolDBOutputService
methods
#36142
Migrate HLTPrescaleRecorder and AlignPCLThresholdsWriter to new PoolDBOutputService
methods
#36142
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36142/26675
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36142/26677
|
Pull request #36142 was updated. @malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6419b7/20570/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36142/26687
|
Pull request #36142 was updated. @malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6419b7/20577/summary.html Comparison SummarySummary:
|
+hlt @francescobrivio, thanks for taking care of the update in |
+db |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of cms-AlCaDB/AlCaTools#28.
Migrated to use the new PoolDBOutput methods in:
HLTPrescaleRecorder.cc
migrated fromcreateNewIOV+appendSinceTime
towriteOneIOV
AlignPCLThresholdsWriter.cc
I switched from pointer to instance forAlignPCLThresholds myThresholds
PR validation:
Code compiles and
scramv1 b runtests
runs fine.Backport
N/A
FYI @mmusich