Add missing bits to store the phi region for the inner stub in the combined module trackletparameters #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the tracklet parameter memory
tomalin
reviewed
Aug 25, 2023
| @@ -122,6 +122,12 @@ std::string Stub::phiregionaddressstr() const { | |||
| return phiregion.str() + stubindex_.str(); | |||
| } | |||
|
|
|||
| std::string Stub::phiregionstr() const { | |||
| int iphi = (phicorr_.value() >> (phicorr_.nbits() - settings_.nbitsallstubs(layerdisk()))); | |||
| FPGAWord phiregion(iphi, 3, true, __LINE__, __FILE__); | |||
There was a problem hiding this comment.
Magic numbers like "3" should be avoided, so try to replace this with a named constant sometime.
tomalin
pushed a commit
that referenced
this pull request
Aug 25, 2023
… in the tracklet parameter memory (#233)
Merged
tomalin
pushed a commit
that referenced
this pull request
Nov 15, 2023
… in the tracklet parameter memory (#233)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is a simple change to add three bits to store the phi region to identify which AllStub memory is used in a combined module seed.
PR validation:
I have run this code in CMSSW and produced the test vectors for HLS. I have updated the HLS code to handle these additional bits and checked that the code is working. (PR for HLS is not quite ready yet, some cleanup still needed.)