TrackFit phi region #236
Merged
TrackFit phi region #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this nee to be updated tow add the three bits for both seeding layers? |
@aryd I already added the three bits for both seeding layers. So it should be good to go AFAIK. I updated the PR description to reflect this. |
tomalin
pushed a commit
that referenced
this pull request
Dec 29, 2023
* Added phi region to TrackFit memory output. * Added phi region of other seed stub.
tomalin
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Added phi region to TrackFit memory output. * Added phi region of other seed stub.
tomalin
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Added phi region to TrackFit memory output. * Added phi region of other seed stub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR adds six bits to the TrackFitMemory output, which represent the phi regions of the two seed stubs. It's similar to what PR #233 did for TrackletParametersMemory, but now for TrackFitMemory, and for both seed stubs.
PR validation:
I generated test vectors with these changes, and the added bits are now present.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A