Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrained tau model #7

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Add retrained tau model #7

merged 2 commits into from
Feb 15, 2024

Conversation

Duchstf
Copy link
Contributor

@Duchstf Duchstf commented Apr 5, 2023

Hello, this is a PR to update the tau NN in association with this PR: cms-l1t-offline/cmssw#1087

Duc.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

A new Pull Request was created by @Duchstf (Duc Hoang) for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger, @cecilecaillol can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2023

Pull request #7 was updated.

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/33034/summary.html
COMMIT: 71c219c
CMSSW: CMSSW_13_2_X_2023-06-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1ParticleFlow/7/33034/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 07-Jun-2023 17:43:25 CEST-----------------------
An exception of category 'InvalidRun' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Calling method for module L1NNTauProducer/'l1tNNTauProducerPuppi'
Exception Message:
error while running session: Invalid argument: Tensor input_1:0, specified in either feed_devices or fetch_devices was not found in the Graph
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 07-Jun-2023 17:43:39 CEST-----------------------
An exception of category 'InvalidRun' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1NNTauProducer/'l1tNNTauProducerPuppi'
Exception Message:
error while running session: Invalid argument: Tensor input_1:0, specified in either feed_devices or fetch_devices was not found in the Graph
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 07-Jun-2023 17:52:22 CEST-----------------------
An exception of category 'InvalidRun' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1NNTauProducer/'l1tNNTauProducerPuppi'
Exception Message:
error while running session: Invalid argument: Tensor input_1:0, specified in either feed_devices or fetch_devices was not found in the Graph
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@aloeliger
Copy link
Contributor

please test with cms-sw/cmssw#41492

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/33038/summary.html
COMMIT: 71c219c
CMSSW: CMSSW_13_2_X_2023-06-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1ParticleFlow/7/33038/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/33038/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/33038/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
10805.31 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219884
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@AdrianoDee
Copy link

+upgrade
(Would wait for #41492)

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/36299/summary.html
COMMIT: 71c219c
CMSSW: CMSSW_14_0_X_2023-12-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1ParticleFlow/7/36299/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/36299/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12b0f/36299/git-merge-result

Comparison Summary

Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3370032
  • DQMHistoTests: Total failures: 82
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3369928
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

@smuzaffar @iarspider Ping on this, this is related to a PR that has been merged for some time now.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 390f108 into cms-data:master Feb 15, 2024
9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants