Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities/StaticAnalyzers: updates to address changes in number of reports with llvm 14/16 #41861

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 4, 2023

Use emitReport with BugType pointer instead of emitBasicReport.
Enable function/class checker bug reports.

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Jun 4, 2023
@gartung gartung changed the title Utilities/StaticAnalyzers: updates to address changes in number of reports with llvm 16 Utilities/StaticAnalyzers: updates to address changes in number of reports with llvm 14/16 Jun 4, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41861/35765

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41861/35766

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

  • Utilities/StaticAnalyzers (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Jun 4, 2023

please test with cms-sw/cmsdist#8537

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42bc99/32968/summary.html
COMMIT: aa52c5d
CMSSW: CMSSW_13_2_X_2023-06-04-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41861/32968/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42bc99/32968/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42bc99/32968/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221457
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221426
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Jun 7, 2023

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2023

+1

@cmsbuild cmsbuild merged commit b538351 into cms-sw:master Jun 7, 2023
@gartung gartung deleted the gartung-SA-work branch June 13, 2023 20:38
@gartung gartung restored the gartung-SA-work branch June 13, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants