Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Correlator layer 1 barrel "TDR" regionizer emulator #1134

Conversation

gpetruc
Copy link

@gpetruc gpetruc commented Jun 1, 2023

PR description:

This PR propagates to cms-l1t-offline two correlator updates to the Barrel "TDR" regionizer, from @jmitrevs:

Note that the default configuration of the correlator emulator is running the "ideal" regionizer in the barrel, so no changes at all are expected in the physics output with this PR.
A switch to the "TDR" emulator in the default configuration may happen in a later PR after physics validation.

It also brings the head of the correlator fork mostly up to date to cms-l1t-offline.

Apologies for the number of commits, but we can't do any rebase of it in this branch since the first of the two PRs was merged on our side quite some time ago before we started synchronizing with cms-l1t-offline and cms-sw/master for all individual PRs

PR validation:

  • passes standard code checks
  • L1Trigger/Phase2L1ParticleFlow/test/make_l1ct_binaryFiles_HGCTest_cfg.py runs successfully
  • correlator-common CI runs successfully
  • in the CMSSW master version, RelVal matrix workflow 23234.0 runs

CMSSW master PR

cms-sw#41838

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no files with code format issues!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Emulator Development Emulator development PR labels Jun 2, 2023
@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

  • L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@epalencia epalencia merged commit 274225b into cms-l1t-offline:phase2-l1t-integration-1252patch1 Jun 28, 2023
@epalencia
Copy link

Tagged as l1t-phase2-v69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emulator Development Emulator development PR Phase-2 Pertains to phase-2 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants