Update tdr barrel regionizer emulator

[jmitrevs]

PR description:

This updates the tdr barrel emulator. It generally matches results with the firmware in:

https://gitlab.cern.ch/cms-cactus/phase2/firmware/correlator-common/-/merge_requests/134

The one issue that remains is that the processing delays are not 100% accurately modeled, so data coming from different fibers can appear in different order in the output between the emulator and the simulation. (The TDR emulator was never 100% accurate on this.) This includes an attempt to model this better, but it's not quite there.

PR validation:

This is mainly tested manually comparing emulator and simulator using scripts in in correlator-layer1. I will comment on the related PR once I make it.

[gpetruc]

At a quick look it seems ok to me.
Since this will have to be ported also to cms-l1t-offline and the master branch of central cmssw , I would suggest you to squash all into a single commit - that would make the rebase to cmssw master easier.

[jmitrevs]

For squashing into a single commit, you mean that when this is merged, you will use the "Squash and Merge" option, or is there something I need to do before?

[gpetruc]

I think it's best if you squash the commits locally and force-push the new commit here.
That way, you can then also open a PR to cms-l1t-offline with the same branch, and a PR to cmssw master with a rebase of that commit on the latest CMSSW 13_2_X IB

[jmitrevs]

I may have a solution to the order problem I am still seeing, so I may want to include a few more commits before squashing. It should be within the next few days.

[jmitrevs]

I fixed the order issue and squashed this commit.

[jmitrevs]

I pushed another commit here as requested in the review in cms-sw#41838. If you agree with the response to that request, we should cherry-pick the answer. If not, let me know what is the best way to fix it.

[gpetruc]

Yep, I'll cherry-pick it on the other PRs (monday). Il Sab 3 Giu 2023, 00:24 Jovan Mitrevski ***@***.***> ha scritto:

…

I pushed another commit here as requested in the review in cms-sw#41838 <cms-sw#41838>. If you agree with the response to that request, we should cherry-pick the answer. If not, let me know what is the best way to fix it. — Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDNWR7MYFRBHBPK6VKSPBLXJJRYDANCNFSM6AAAAAAXXWAK3E> . You are receiving this because you commented.Message ID: ***@***.***>

[gpetruc]

Ok, the PRs to upstream are not yet merged but they are fully signed so I can merge this.
To stay better in sync with cms-l1t-offline in fact I'll merge the branch used to make cms-l1t-offline#1134 which has the cherry-pick of the last commit instead of the original one

[gpetruc]

effectively merged.