Fixes in the RPC clusterization in the L1Trigger/L1TMuonOverlapPhase1 (backport from master) #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fline with cms-merge-topic
Implementation of the RPC clusterization that should be with agreement with the OMTF firmware from Nov 2021. In the emulator, if option dropAllClustersIfMoreThanMax is used, then if any cluster is dropped in a given barrel roll or endcap chamber (because it is bigger than RpcMaxClusterSize or there is more than 2 of them) - all clusters are dropped for this roll/chamber. Besides better data-to-emulator agreement it provides better efficiency for high pt muons. MuonStub.h: added RPC_DROPPED to the enum Type RpcClusterization::getClusters: if the option dropAllClustersIfMoreThanMax is usded, the order of the output clusters is the same as the order of the input digi. The clusters are not dropped here. OMTFinputMaker.cc pcDigiToStubsConverterOmtf::addRPCstub - when the stub is added, its type can be set to RPC_DROPPED. MuonStubMakerBase.cc: RpcDigiToStubsConverter::makeStubs: at the end of processing, the RPC stubs that were mark as RPC_DROPPED are removed from the processed muonStubsInLayers. (cherry picked from commit 3d6774d)
epalencia
changed the title
epalencia
force-pushed
the
my_development_branch_feb3
branch
from
2bef6c9 to
f207656
Compare
|
Tagged as l1t-integration-v115.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Backport of PR36827: Fixes in the RPC clusterization in the L1Trigger/L1TMuonOverlapPhase1