Fixes in the RPC clusterization in the L1Trigger/L1TMuonOverlapPhase1 #36827
Conversation
Implementation of the RPC clusterization that should be with agreement with the OMTF firmware from Nov 2021. In the emulator, if option dropAllClustersIfMoreThanMax is used, then if any cluster is dropped in a given barrel roll or endcap chamber (because it is bigger than RpcMaxClusterSize or there is more than 2 of them) - all clusters are dropped for this roll/chamber. Besides better data-to-emulator agreement it provides better efficiency for high pt muons. MuonStub.h: added RPC_DROPPED to the enum Type RpcClusterization::getClusters: if the option dropAllClustersIfMoreThanMax is usded, the order of the output clusters is the same as the order of the input digi. The clusters are not dropped here. OMTFinputMaker.cc pcDigiToStubsConverterOmtf::addRPCstub - when the stub is added, its type can be set to RPC_DROPPED. MuonStubMakerBase.cc: RpcDigiToStubsConverter::makeStubs: at the end of processing, the RPC stubs that were mark as RPC_DROPPED are removed from the processed muonStubsInLayers.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36827/27991
|
|
A new Pull Request was created by @kbunkow for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58c3fa/22094/summary.html Comparison SummarySummary:
|
|
@kbunkow Is this included in our integration branch or does it need to be backported? |
@cecilecaillol No, this PR is not included in the https://github.com/cms-l1t-offline, as the L1TMuonOverlapPhase1 was not present there before it was rebased to l1t-‐integration_CMSSW_12_3_0 |
|
ok then i will port it to our new integration branch |
|
+l1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Implementation of the RPC clusterization that should be in agreement with the updated OMTF firmware from November 2021. In the emulator, if the option dropAllClustersIfMoreThanMax is used, then if any cluster is dropped in a given barrel roll or endcap chamber (because it is bigger than RpcMaxClusterSize or there is more than 2 of them) - all clusters are dropped for this roll/chamber. Besides the better data-to-emulator agreement it provides better efficiency for high pt muons. The OMTF emulator should be backward compatible with the run2 data.
what changes are expected in the output if any:
better data-to-emulator agreement for OMTF muon trigger for the data with the OMTF firmware from Nov 2021 (https://its.cern.ch/jira/browse/CMSLITOPS-272) ,
no significant changes in the data-to-emulator agreement for the run2 data.
what other PRs or externals it depends upon if any
None
PR validation:
scram b runtests - OK
runTheMatrix.py -l limited -i all --ibeos - OK
The DQM was run locally in order to check the plots for showing the OMTF data-to-emulator agreement. Results:
if this PR is a backport please specify the original PR and why you need to backport that PR:
It is not a backport