-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rivet 2.7.2 and YODA 1.75 #5005
Rivet 2.7.2 and YODA 1.75 #5005
Conversation
A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_0_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
allow @intrepid42 test rights |
now you can test the PR and retry it if it needs retriggering |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 4349842 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/MergedGenParticleProducer.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc: In constructor 'RivetAnalyzer::RivetAnalyzer(const edm::ParameterSet&)': /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc:50:29: error: 'CmpAnaHandle' was not declared in this scope const std::set& analyses = _analysisHandler.analyses(); ^~~~~~~~~~~~ /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-23-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc:50:41: error: template argument 2 is invalid const std::set& analyses = _analysisHandler.analyses(); ^ |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Need to update RivetInterface for https://bitbucket.org/heprivet/rivet/commits/6ae4b32acee01c19b4fc064fa168e1083a61621c |
please test with cms-sw/cmssw#26936 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@smuzaffar ok for me to move forward at next IB |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Rivet and YODA minor revision updates