Adapt RivetInterface for Rivet 2.7.2

[mseidel42]

PR description:

Update RivetInterface for Rivet Core change https://bitbucket.org/heprivet/rivet/commits/6ae4b32acee01c19b4fc064fa168e1083a61621c

PR validation:

RivetInterface runs successfully with new Rivet release 2.7.2

Needs cms-sw/cmsdist#5005

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5005
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/503/console Started: 2019/05/24 18:25

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26936/9977

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@alberto-sanchez, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 21261d6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc490d/503/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc490d/503/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206856
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3206521
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@intrepid42 could you please clarify what is the interface change that needs adaptation? I see essentially a slightly modified loop for AnaHandle...

[mseidel42]

Hi Fabio

• CmpAnaHandle was deleted in Rivet core
• Rivet::AnalysisHandler::analyses() changed from const std::set<AnaHandle, CmpAnaHandle>& analyses() const to std::vector<AnaHandle> analyses() const so that we had to get rid of CmpAnaHandle
• Switched to range-based for loop in addition (like it is done in Rivet core also)

[fabiocos]

@intrepid42 thanks for the clarification, so it is effectively a small adjustment, although a needed one

[fabiocos]

+1

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5008
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/541/console Started: 2019/05/27 17:53

[cmsbuild]

-1

Tested at: 21261d6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c769d/541/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testmat had ERRORS
---> test testDDCompactView had ERRORS
---> test dumpDDExpandedView had ERRORS
---> test dumpDDCompactView had ERRORS
---> test edmCatalogFileLocator_t had ERRORS
---> test TestFWCoreIntegrationStandalone had ERRORS
---> test unitTestsGroup_4 had ERRORS
---> test unitTestsGroup_1 had ERRORS

[cmsbuild]

Comparison job queued.