Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch v6-24-00-patches #7903

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

smuzaffar
Copy link
Contributor

backport of #7890
This has been integrated in to DEVEL IBs and it looks good ( have not seen any issues yet )

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_5_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0305b9/25088/summary.html
COMMIT: b9a36f9
CMSSW: CMSSW_12_5_X_2022-05-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7903/25088/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0305b9/25088/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0305b9/25088/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 377 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3648315
  • DQMHistoTests: Total failures: 1126
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3647166
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@makortel
Copy link
Contributor

makortel commented May 31, 2022

On a quick look the differences look similar as in cms-sw/cmssw#37868 (comment). E.g. 10024.0 Tracking/Track/cutsRecoBtvLike_trackingParticleRecoAsssociation/chi2mean_vs_phi there (BinToBin: 9.47E-01)
image

and here (BinToBin: 9.47E-01)
image

cms-sw/cmssw#37868 was included in CMSSW_12_5_X_2022-05-30-2300, and here the the reference IB was CMSSW_12_5_X_2022-05-30-1100.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0305b9/25103/summary.html
COMMIT: b9a36f9
CMSSW: CMSSW_12_5_X_2022-05-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7903/25103/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3648309
  • DQMHistoTests: Total failures: 1292
  • DQMHistoTests: Total nulls: 37
  • DQMHistoTests: Total successes: 3646958
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 833.5120000000001 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 132.827 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 6.138 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0,... ): -0.047 KiB HLT/TAU
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 49 workflows

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0305b9/25145/summary.html
COMMIT: b9a36f9
CMSSW: CMSSW_12_5_X_2022-05-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7903/25145/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3649923
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3649899
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals
comparison results looks good now

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

I am merging this for 12.5.X. This is also needed for gcc 12 ( see root-project/root#10596 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants