-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated root to tip of branch v6-24-00-patches #7903
Conversation
please test |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_5_X/master. @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
please test |
On a quick look the differences look similar as in cms-sw/cmssw#37868 (comment). E.g. 10024.0 cms-sw/cmssw#37868 was included in CMSSW_12_5_X_2022-05-30-2300, and here the the reference IB was CMSSW_12_5_X_2022-05-30-1100. |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
I am merging this for 12.5.X. This is also needed for gcc 12 ( see root-project/root#10596 ) |
backport of #7890
This has been integrated in to DEVEL IBs and it looks good ( have not seen any issues yet )