Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxxmodules] Reduce the amount of header duplications in the modules. [v6.24] #10596

Merged
merged 1 commit into from
May 17, 2022

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented May 17, 2022

This resolves a merging bug with libstdc++12. Fixes #10478

Backport includes the following commit:
[cxxmodules] Fix std.modulemap for older GCC (#10529)

The header bits/utility.h only exists since libstdc++-12.

(cherry picked from commits e88d533
and 2750395)

Backport of PRs #10498 and #10529

This resolves a merging bug with libstdc++12. Fixes root-project#10478

Backport includes the following commit:
    [cxxmodules] Fix std.modulemap for older GCC (root-project#10529)

    The header bits/utility.h only exists since libstdc++-12.

(cherry picked from commits e88d533
and 2750395)
@hahnjo hahnjo added this to the 6.24/08 milestone May 17, 2022
@hahnjo hahnjo requested a review from vgvassilev May 17, 2022 08:06
@hahnjo hahnjo requested a review from Axel-Naumann as a code owner May 17, 2022 08:06
@hahnjo hahnjo self-assigned this May 17, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@hahnjo hahnjo merged commit c33b413 into root-project:v6-24-00-patches May 17, 2022
@hahnjo hahnjo deleted the gcc12-v624 branch May 17, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants