Update TBB to version 2021.9.0

[smuzaffar]

• Update TBB version 2021.9.0
• Drop TBB patch Actualize documentation about proportional splitting constructor in Range uxlfoundation/oneTBB#728 which is now included in TBB version 2021.9.0

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_2_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b46d72/33238/summary.html
COMMIT: 0ee5c32
CMSSW: CMSSW_13_2_X_2023-06-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8553/33238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 98 lines from the logs
• Reco comparison results: 72 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 265
• DQMHistoTests: Total nulls: 16
• DQMHistoTests: Total successes: 3195759
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.6559999999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.164 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 12434.0,... ): 0.492 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 312.0 ): 0.164 KiB L1T/L1TStage2uGT
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b46d72/33267/summary.html
COMMIT: 0ee5c32
CMSSW: CMSSW_13_2_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8553/33267/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3197958
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3197927
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

SiStripDAQ_O2O_test unit test failure is not related to this change.

@makortel any objection on updating TBB to latest version 2021.9.0 ?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

Based on the oneTBB release notes no objections.

[makortel]

So far we have seen three crashes that are clearly related to TBB

• one on x86 Segfault in TestDQMOnlineClient-visualization cmssw#42093
• two on ARM [ARM] Segfault in mkfit::MkBuilder::findTracksCloneEngine cmssw#42071 and [ARM] Segfault in RelVal wf 136.874 tbb::detail::d2::concurrent_queue cmssw#42106

After looking the diff between 2021.8.0 and 2021.9.0 uxlfoundation/oneTBB@v2021.8.0...v2021.9.0 I see changes in concurrent_queue that give me a bit uneasy feeling. Given the closeness of last open pre-release of 13_2_0_pre3 in two weeks, how about we revert this update for that, and do the update again after 13_3_X becomes open?

@smuzaffar @cms-sw/externals-l2

[smuzaffar]

I am fine with the revert.

[makortel]

I opened also an issue in uxlfoundation/oneTBB#1139