Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update TBB to version 2021.9.0" #8574

Conversation

makortel
Copy link
Contributor

Reverts #8553 as agreed in #8553 (comment) as a precaution for the last open pre-release of 13_2_X. To be re-reverted after we open 13_3_X.

@cms-sw/orp-l2 This PR should enter in CMSSW_13_2_0_pre3 (merged preferably some IBs before cutting the release)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for branch IB/CMSSW_13_2_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07f588/33453/summary.html
COMMIT: deebd9c
CMSSW: CMSSW_13_2_X_2023-06-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8574/33453/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193832
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193806
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor

Hello @makortel, can we already merge this PR? I think tests look good

@makortel
Copy link
Contributor Author

@aandvalenzuela I'd say yes.

Just for the record, 12434.0 shows cms-sw/cmssw#41200.

@aandvalenzuela aandvalenzuela merged commit ad39f53 into cms-sw:IB/CMSSW_13_2_X/master Jun 30, 2023
@makortel makortel deleted the revert-8553-tbb-2021.9.0 branch August 15, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants