grpcio: Changes backported from TF 2.15 branch #9015
Conversation
|
please test |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_1_X/master. @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Pull request #9015 was updated. |
|
@iarspider , can you please try building it locally. I think grpcio is not linking absl libs as it is looking for those libs under /usr/lib |
|
please test |
|
Pull request #9015 was updated. |
|
@iarspider , looks like you are not applying the newly added patch grpcio-absl-path.patch . log file https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c095c1/37454/externals/py3-grpcio/1.60.1-e281228763f985e50a5c701b73938cd9/ should that it is still not linking our absl libs |
| if BUILD_WITH_SYSTEM_ABSL: | ||
| EXTENSION_LIBRARIES += tuple( | ||
| - lib.stem[3:] for lib in pathlib.Path("/usr").glob("lib*/libabsl_*.so") | ||
| + lib.stem[3:] for lib in pathlib.Path(os.getenv("ABSEIL_CPP_ROOT")).glob("lib*/libabsl_*.so") |
There was a problem hiding this comment.
@iarspider , is lib.stem[3:] correct for our path?
There was a problem hiding this comment.
Yes: stem is "the final path component, without its suffix". So this line strips "lib" prefix and last suffix (extension)
|
Pull request #9015 was updated. |
|
please test |
|
@iarspider , we also have https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_14_1_X/master/c-ares.spec and I see grpcio is using the one from its thrid-party area. Can you configure it to use ours? |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c095c1/37460/summary.html Comparison SummarySummary:
|
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
FYI @iarspider