Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildRule: set env SCRAM_ALPAKA_BACKEND for unit tests #9068

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 13, 2024

New build rules now can set SCRAM_ALPAKA_BACKEND env to one of the valid alpaka backends e.g SerialSync, CudaAsync, ROCmAsync during the scram build runtests.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 13, 2024

test parameters:

  • full_cmssw = true
  • enable = gpu

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@smuzaffar, @iarspider, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@fwyzard
Copy link
Contributor

fwyzard commented Mar 13, 2024

@smuzaffar, would it be possible to use either

  • serial_sync, cuda_async, rocm_async
  • or SerialSync, CudaAsync, ROCmAsync

?

We already have two set of names to handle, I would prefer to avoid introducing a third one 🤷🏻‍♂️

@smuzaffar
Copy link
Contributor Author

scram knows SerialSync, CudaAsync, ROCmAsync , so I can use these

@cmsbuild
Copy link
Contributor

Pull request #9068 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: GpuUnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5663a/38104/summary.html
COMMIT: 618f529
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9068/38104/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5663a/38104/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5663a/38104/git-merge-result

GPU Unit Tests

I found 1 errors in the following unit tests:

---> test testTFVisibleDevicesCUDA had ERRORS

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

TF gpu unit test is known failure in GPU IBs

@smuzaffar smuzaffar merged commit 161fc36 into IB/CMSSW_14_1_X/master Mar 14, 2024
12 of 13 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants