Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ONNXRuntime to 1.17.1 #44354

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

valsdav
Copy link
Contributor

@valsdav valsdav commented Mar 8, 2024

PR description:

Updating ONNXRuntime to 1.17.1 to be able to update CUDA to 12.4.

  • Headers have been moved in ONNXRuntime 1.17.1

PR validation:

To be tested with cms-sw/cmsdist#9046

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cf864/38023/summary.html
COMMIT: d1a1523
CMSSW: CMSSW_14_1_X_2024-03-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44354/38023/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cf864/38023/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cf864/38023/git-merge-result

Comparison Summary

Summary:

  • You potentially added 19195 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 66 log files, 0 edm output root files, 1 DQM output files

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#9046

@fwyzard
Copy link
Contributor

fwyzard commented Mar 12, 2024

We just tested it yesterday ...

@smuzaffar
Copy link
Contributor

@fwyzard , I am worried about the You potentially added 19195 lines to the logs statement and error lines like [a] in the comparison logs. CMSSW_14_1_X_2024-03-10-0000 IB was broken so that is why I want to rerun tests here

[a]

22 Lines only in /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/CMSSW_14_1_X_2024-03-10-0000/1000.0_RunMinBias2011A/step2_RunMinBias2011A.log
   Traceback (most recent call last):
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/bin/el8_amd64_gcc12/cmsDriver.py", line 40, in <module>
   run()
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/bin/el8_amd64_gcc12/cmsDriver.py", line 16, in run
   configBuilder.prepare()
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/Configuration/Applications/python/ConfigBuilder.py", line 2284, in prepare
   self.loadAndRemember(self.EVTCONTDefaultCFF)  #load the event contents regardless
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/Configuration/Applications/python/ConfigBuilder.py", line 354, in loadAndRemember
   self.process.load(includeFile)
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/FWCore/ParameterSet/python/Config.py", line 761, in load
   module = __import__(moduleName)
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/Configuration/EventContent/python/EventContent_cff.py", line 64, in <module>
   from RecoHGCal.Configuration.RecoHGCal_EventContent_cff import *
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/RecoHGCal/Configuration/python/RecoHGCal_EventContent_cff.py", line 3, in <module>
   from RecoHGCal.TICL.iterativeTICL_cff import ticlIterLabelsMerge
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/RecoHGCal/TICL/python/iterativeTICL_cff.py", line 16, in <module>
   from RecoHGCal.TICL.tracksterSelectionTf_cfi import *
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/src/RecoHGCal/TICL/python/tracksterSelectionTf_cfi.py", line 1, in <module>
   from PhysicsTools.TensorFlow.tfGraphDefProducer_cfi import tfGraphDefProducer as _tfGraphDefProducer
   File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-03-10-0000/cfipython/el8_amd64_gcc12/PhysicsTools/TensorFlow/tfGraphDefProducer_cfi.py", line 5, in <module>

@fwyzard
Copy link
Contributor

fwyzard commented Mar 12, 2024

Understood 👍🏻

@smuzaffar
Copy link
Contributor

@cms-sw/ml-l2 , this looks good. Can you please sign it. This is needed for cms-sw/cmsdist#9046

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmsdist#9046, please check if they should be merged together

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cf864/38065/summary.html
COMMIT: d1a1523
CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44354/38065/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cf864/38065/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cf864/38065/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2808 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 5665
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3291698
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.011 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.011 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@valsdav
Copy link
Contributor Author

valsdav commented Mar 13, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9046

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants