Fix Looper type name used in python

[Dr15Jones]

PR description:

• auto generated cfi.py files had wrong python type name

PR validation:

Code compiles. A hand import of a newly generated file into python does work.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44406/39479

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/ParameterSet (core)

@smuzaffar, @Dr15Jones, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@wddgit, @missirol, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0ed4c/38142/summary.html
COMMIT: 1fa5fa2
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44406/38142/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [ROOTMaster] Fix include for RNTuple* (redo of #44256) #44328
• @valsdav Updating ONNXRuntime to 1.17.1 #44354
• @mmusich add input / output LA TkDetMaps in SiStripLorentzAnglePCLHarvester #44370

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0ed4c/38142/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0ed4c/38142/git-merge-result

Build

I found compilation error when building:

>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory
   19 | #include "onnxruntime/onnxruntime_cxx_api.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package CalibTracker/SiStripLorentzAngle
>> Entering Package FWCore/ParameterSet
>> Entering Package PhysicsTools/NanoAOD
>> Entering Package PhysicsTools/ONNXRuntime
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-03-13-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-03-13-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/OfflineValidation
>> Compiling  src/Alignment/OfflineValidation/bin/DMRmerge.cc
>> Compiling  src/Alignment/OfflineValidation/bin/Options.cc


[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0ed4c/38168/summary.html
COMMIT: 1fa5fa2
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44406/38168/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 99 lines to the logs
• Reco comparison results: 51 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297354
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Comparisons show the usual

• Non reproducibility in wf 136.793 #43293
• Non-reproducibility in TriggerResults in 24834.0, 24834.911, and 25034.999 #43790

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+core

Would this be the case of testing with full_cmssw ?

[makortel]

In this case the presently the generated _cfi.py file for EDLoopers are simply wrong and would not pass even running python3 ..._cfi.py. I didn't find any matches to EDLooper in the cfipython repository https://github.com/cms-sw/cmssw-cfipython/tree/CMSSW_14_1_X (nor any EDLooper in CMSSW that would implement fillDescriptions()).

Therefore this PR should not have any practical impact on the present state of CMSSW. I'm not against testing full_cmssw (or delaying the merge until Monday) if you want to play safe.

[antoniovilela]

In this case the presently the generated _cfi.py file for EDLoopers are simply wrong and would not pass even running python3 ..._cfi.py. I didn't find any matches to EDLooper in the cfipython repository https://github.com/cms-sw/cmssw-cfipython/tree/CMSSW_14_1_X (nor any EDLooper in CMSSW that would implement fillDescriptions()).

Therefore this PR should not have any practical impact on the present state of CMSSW. I'm not against testing full_cmssw (or delaying the merge until Monday) if you want to play safe.

Many thanks for checking. Seems indeed it would be overcautious. Let's merge it.

[antoniovilela]

+1