Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-arch build for unit tests #9137

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

smuzaffar
Copy link
Contributor

This change should allow to build/run unit tests for multi-archs. Each unit tests executable will be build for all enabled multi-archs and at runtime scram build (runtests|unittests) or scram build (runtests|unittests)_TestName will run the correct unit tests

@smuzaffar smuzaffar changed the title Enable multi-arch build for unit tests\ Enable multi-arch build for unit tests Apr 15, 2024
@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b111aa/38850/summary.html
COMMIT: 460fba0
CMSSW: CMSSW_14_1_X_2024-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9137/38850/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b111aa/38851/summary.html
COMMIT: 460fba0
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-04-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9137/38851/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b111aa/38851/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b111aa/38851/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test test-rivet-list had ERRORS
---> test test-rivet-run had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially removed 273 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 70086 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3317863
  • DQMHistoTests: Total failures: 305259
  • DQMHistoTests: Total nulls: 273
  • DQMHistoTests: Total successes: 3012311
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3144.7369999999996 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.586 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 0.247 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 12834.0,... ): 448.699 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12834.0,... ): 0.445 KiB HLT/Filters
  • DQMHistoSizes: changed ( 13034.0 ): -2.906 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 0.120 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 140.043,... ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.086 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

@smuzaffar smuzaffar merged commit 73299ff into IB/CMSSW_14_1_X/master Apr 16, 2024
14 of 16 checks passed
@smuzaffar smuzaffar deleted the multiarch-unittests branch April 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants