Prevent geniso to be run in nanogen

[namapane]

PR description:

Address #44664.
The fix just prevents genIso to be run in the nanogen sequence as suggested by @vlimant [here].

The genIso module might be refactored at a later time to make it work also in the nanogen sequence by relying only on genparticles.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44709/39915

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Explicit lazy parsing in SimpleFlatTableProducer #44575

[cmsbuild]

A new Pull Request was created by @namapane for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

please test workflow 546.0,547.0,548.0

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-954d85/38784/summary.html
COMMIT: 53d0c8a
CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44709/38784/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 216 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316240
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 210 log files, 173 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16484
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16484
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.574	2.574	0.000 ( +0.0% )	4.54	4.47	+1.7%	2.231	2.107
2500.001	2.722	2.722	0.000 ( +0.0% )	4.04	4.01	+0.7%	2.647	2.528
2500.002	2.667	2.667	0.000 ( +0.0% )	4.23	4.14	+2.2%	2.644	2.520
2500.01	1.318	1.318	0.000 ( +0.0% )	8.27	8.14	+1.6%	2.293	2.194
2500.011	1.739	1.739	0.000 ( +0.0% )	4.59	4.51	+1.8%	2.533	2.352
2500.012	1.580	1.580	0.000 ( +0.0% )	6.48	6.38	+1.7%	2.409	2.326
2500.1	2.218	2.218	0.000 ( +0.0% )	4.57	4.52	+1.2%	2.066	1.949
2500.2	2.333	2.333	0.000 ( +0.0% )	5.17	5.14	+0.7%	1.974	1.852
2500.21	1.182	1.182	0.000 ( +0.0% )	3.51	3.47	+1.2%	2.267	2.146
2500.211	1.546	1.546	0.000 ( +0.0% )	3.11	3.10	+0.5%	2.338	2.168
2500.3	2.089	2.089	0.000 ( +0.0% )	9.69	9.81	-1.3%	1.961	1.851
2500.301	2.667	2.667	0.000 ( +0.0% )	8.21	8.14	+0.8%	1.948	1.784
2500.31	7.159	7.159	0.000 ( +0.0% )	1.38	1.38	-0.1%	1.702	1.660
2500.311	1.564	1.564	0.000 ( +0.0% )	6.15	6.40	-4.0%	1.047	1.053
2500.312	540.453	540.453	0.000 ( +0.0% )	0.50	0.51	-2.5%	1.597	1.507
2500.313	817.689	817.689	0.000 ( +0.0% )	0.71	0.72	-1.7%	1.582	1.487
2500.32	1.256	1.256	0.000 ( +0.0% )	12.70	12.75	-0.4%	2.348	2.214
2500.321	1.643	1.643	0.000 ( +0.0% )	9.44	9.19	+2.8%	2.387	2.377
2500.322	1.163	1.163	0.000 ( +0.0% )	9.82	9.87	-0.4%	2.105	2.054
2500.323	7.768	7.768	0.000 ( +0.0% )	3.08	3.03	+1.7%	1.922	1.780
2500.324	1.759	1.759	0.000 ( +0.0% )	9.75	9.94	-1.9%	2.177	2.150
2500.325	4.144	4.144	0.000 ( +0.0% )	4.09	4.16	-1.6%	2.211	2.207
2500.326	3.095	3.095	0.000 ( +0.0% )	1.73	1.76	-1.8%	2.179	2.155
2500.327	1.791	1.791	0.000 ( +0.0% )	9.89	9.84	+0.5%	2.344	2.154
2500.4	2.245	2.245	0.000 ( +0.0% )	9.31	9.51	-2.1%	1.805	1.795
2500.401	1.778	1.778	0.000 ( +0.0% )	8.13	8.27	-1.6%	1.702	1.685
2500.402	2.795	2.795	0.000 ( +0.0% )	8.03	8.09	-0.7%	1.909	1.749
2500.403	8.752	8.752	0.000 ( +0.0% )	2.71	2.74	-1.0%	1.865	1.779
2500.404	5.105	5.105	0.000 ( +0.0% )	1.31	1.32	-0.6%	1.798	1.781
2500.405	2.803	2.803	0.000 ( +0.0% )	7.89	7.93	-0.5%	1.792	1.738
2500.5	5.192	5.192	0.000 ( +0.0% )	15.68	15.79	-0.7%	1.573	1.572
2500.51	9.119	9.119	0.000 ( +0.0% )	9.58	9.56	+0.2%	1.512	1.515

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

Why are we deleting an element in a sequence rather than not adding it in the first place? This will be extremely confusing to people looking through the code.

[hqucms]

Why are we deleting an element in a sequence rather than not adding it in the first place? This will be extremely confusing to people looking through the code.

@rappoccio We are only removing it when running NanoGEN from GEN, while still keeping it when running NanoGEN from Mini. Anyhow this is meant as a quick fix so as not to block #44654 in 14_0_X, meanwhile we should look for a more proper solution to allow it to run over GEN.

[antoniovilela]

+1