Rivet: use eigen flags; update rivet analysis path for multi-arch

[smuzaffar]

Rivet tests are failing in multi-arch build. Looks like rivet internally has a copyif eigen but in RivetEigen namespace. Just to make sure that we use consistent egien flags I have updated river spec to use CMS_EIGEN_CXX_FLAGS build flags.

Rivet tool sets RIVET_ANALYSIS_PATH pointing to rivet/lib/Rivet. This causes runtime errors for multu-arch builds. Looks like rivet already knows this path. so no need to set it for rivet itself

[a]

python3: ../../include/Rivet/Math/eigen3/src/Core/DenseStorage.h:128: RivetEigen::internal::plain_array<T, Size, MatrixOrArrayOptions, 32>::plain_array() [with T = double; int Size = 4; int MatrixOrArrayOptions = 0]: Assertion `(internal::UIntPtr(eigen_unaligned_array_assert_workaround_gcc47(array)) & (31)) == 0 && "this assertion is explained here: " "http://eigen.tuxfamily.org/dox-devel/group__TopicUnalignedArrayAssert.html" " **** READ THIS WEB PAGE !!! ****"' failed.

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

test parameters:

• addpkg = GeneratorInterface/RivetInterface

[smuzaffar]

please test

[smuzaffar]

please test for CMSSW_14_1_MULTIARCHS_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4bab/38887/summary.html
COMMIT: 0c40a60
CMSSW: CMSSW_14_1_X_2024-04-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9141/38887/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Update tag for RecoBTag-Combined to V01-22-00 #9139

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4bab/38887/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4bab/38887/git-merge-result

Comparison Summary

Summary:

• You potentially added 3202 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 12
• DQMHistoTests: Total histograms compared: 389898
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 389892
• DQMHistoTests: Total skipped: 6
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
• Checked 152 log files, 76 edm output root files, 12 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

unit tests for MULTIARCHS IB passed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4bab/38889/summary.html
COMMIT: 0c40a60
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-04-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9141/38889/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Update tag for RecoBTag-Combined to V01-22-00 #9139
• @belforte Update crab-dev to latest tag #9138

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4bab/38889/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4bab/38889/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

Summary:

• You potentially removed 206 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 70282 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319227
• DQMHistoTests: Total failures: 305239
• DQMHistoTests: Total nulls: 268
• DQMHistoTests: Total successes: 3013700
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 13.160999999999998 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.586 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11634.0,... ): 1.229 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13034.0 ): -2.906 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13234.0,... ): 0.738 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 140.043,... ): -0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): 0.086 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.836 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.469 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): ...
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 18 / 46 workflows