Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0.X]Move to ROOT 6.32 #9541

Open
wants to merge 1 commit into
base: IB/CMSSW_15_0_X/master
Choose a base branch
from
Open

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 28, 2024

Root 6.32 validation looks good cms-sw/cmssw#45556

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_0_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43129/summary.html
COMMIT: 99850ea
CMSSW: CMSSW_15_0_X_2024-11-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9541/43129/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43129/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43129/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestFWCoreModulesEmptySourceFromEventIDs had ERRORS
---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

unit tests failure are know:

  • TestFWCoreModulesEmptySourceFromEventIDs: know issue with this unit tests (see Fix EmptySourceFromEventIDs test configuration cmssw#46825 )
  • TestFWCoreReflectionClassVersionUpdate : Always fails for PR tests when root version is updated
  • TestIOPoolInputNoParentDictionary: Always fails for PR tests when root version is updated

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants