-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EmptySourceFromEventIDs
test configuration
#46825
base: master
Are you sure you want to change the base?
Conversation
please test |
type bugfix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46825/42830 |
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+core This PR only touches unit test |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
Fix the
EmptySourceFromEventIDs
test configuration.The
EventIDChecker
module requires that events be created and analysed in a specific order, which cannot be guaranteed in a multi-stream, multi-threaded configuration.PR validation:
The
TestFWCoreModulesEmptySourceFromEventIDs
unit test should now pass.