-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Items needed but not yet signed for pre3 #18449
Comments
A new Issue was created by @davidlange6 David Lange. @davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
hi @davidlange6 , it would be great to have : |
@davidlange6 thanks - one more item is modifications to aging.py for HCAL aging scenarios, which I can hopefully submit today (just Python, so it should be easy to test and review). Not sure if ECAL aging conditions will arrive for pre3, but we can put these in global tags to use for production even if they come late. |
#18428 - this feature is long awaited! |
Here are other pending non-technical PRs that require reco signature
|
#18452 is the aforementioned HCAL aging followup PR |
#18456 also needed |
ECAL aging conditions |
If they don't come in time, we can consider making a patch to the upgrade production release to set them in aging.py. |
reco perspective:
On 4/27/17 4:40 AM, David Lange wrote:
Update on remaining items. can we finish these today?
#18321 <#18321>
- looks like today will be conclusive to signoff
- signed already
- will be signed for reco purpose, (ignoring somewhat odd choices made
at digi level)
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18449 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbtlmjvj_8RfwewzTLch7LqqEB6xAks5r0H7DgaJpZM4NGBQa>.
|
#18503 should be considered if possible - if too late, we can apply it as a patch for the phase2 production release |
Ah yes 18199 got dropped. I haven't looked at it since the last rearrangement.
Cheers,
David
On 28 Apr 2017, at 15:40, Kevin Pedro <notifications@github.com<mailto:notifications@github.com>> wrote:
I guess #18199<#18199> somehow missed this list.
Also #18513<#18513> is a bug fix for #18503<#18503> (pretty simple, can be applied as a patch if necessary).
#18488<#18488> came very late...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18449 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw0wDinfU-LG1ZKlzW4cIeFwaFZLvks5r0ewrgaJpZM4NGBQa>.
|
For upgrade (muon tdr validation release)
#17843 (needs L1 signature)
#18387 (code/config organization issues to be solved)
#18373 (needs small update from author)
#18236 (but not essential)
Please add others remaining and issues to be resolved before they can be signed here.
The text was updated successfully, but these errors were encountered: