Link board upgrade #18488
Link board upgrade #18488
Conversation
|
A new Pull Request was created by @bapavlov for master. It involves the following packages: SimMuon/RPCDigitizer @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@bapavlov , in the digi class you substitute cout by emd::LogInfo. It is enough to have one LogInfo statement and than use "\n" as cartrige return, the printout will be more readable. There is special treatment of e-, why not also e+? there is some fraction inside RPC. |
|
@civanch OK. I'll fix an issue with emd::LogInfo. |
|
Hi, @kpedro88, @calabria . Just to let you know that we are planning some changes in the digitizer. |
|
@bapavlov are these changes important/necessary for the muon TDR central production? |
|
@bapavlov , so, you do not apply a special treatment on low-energy e- but exclude it from new SimHits only. Likely majority of e+ will come from e+e- pair creation with not so low energy. Would number of SimHits be reasonable if a threshold (~1 MeV) for e- energy is applied? In that case, extra limit on e+ is not needed. |
|
@kpedro88 yes, the changes are important for the production |
|
@bapavlov needs rebase |
bapavlov
force-pushed
the
LinkBoard_upgrade
branch
from
01cc0ed to
e728bca
Compare
|
Pull request #18488 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
Pull request #18488 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
…(needed for trigger studies)
|
Pull request #18488 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
Pull request #18488 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
Pull request #18488 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
This PR is to be used in the TDR production, so this one have to be back ported to 91X. |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
In the present system the Link Boards readout the RPCs every 25 ns, so although the RPCs has an excellent timing on the end the time is measured in BX (bunch crossings), where 1 BX =25 ns.
For PhaseII the RPC Link Boards are planed to be upgraded. The upgraded PhaseII Link Boards would be able to measure more precisely the RPC time, thus enabling precise time for the whole RPC system. The PR enables upgraded PhaseII Link Board readout to be simulated.
We have added also an option to turn on/off electron digitization in the same way as it's done in the following PR:
##17898