Nancymarinelli/nm700 refinements

[nancymarinelli]

Slava's comments on 700pre7 implemented plus some other code cleaning

[cmsbuild]

A new Pull Request was created by @nancymarinelli for CMSSW_7_0_X.

Nancymarinelli/nm700 refinements

It involves the following packages:

Validation/RecoEgamma
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers
RecoEgamma/PhotonIdentification

@nclopezo, @danduggan, @rovere, @cmsbuild, @thspeer, @deguio, @slava77, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[slava77]

@slava77 working on it

[nancymarinelli]

Hi Marco, Slava,

In this branch Validation was supposed not to enter. Marco please check that does not override the changes you made for the GetBy Label -> GetByToken
Also because I have already asked for a PR on the base of your updates

And Validaation I see is inside Nancymarinelli/nm700 refinements
Would screw all if merged with what already existing
Please let me know. Sorry but I do not still manage to digest GIT too much

Nancy

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: cmsbuild <notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.commailto:reply@reply.github.com>
Date: Thu, 5 Dec 2013 03:58:08 -0800
To: cms-sw/cmssw <cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli <nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Nancymarinelli/nm700 refinements (#1682)

A new Pull Request was created by @nancymarinellihttps://github.com/nancymarinelli for CMSSW_7_0_X.

Nancymarinelli/nm700 refinements

It involves the following packages:

Validation/RecoEgamma
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers
RecoEgamma/PhotonIdentification

@nclopezohttps://github.com/nclopezo, @dandugganhttps://github.com/danduggan, @roverehttps://github.com/rovere, @cmsbuildhttps://github.com/cmsbuild, @thspeerhttps://github.com/thspeer, @deguiohttps://github.com/deguio, @slava77https://github.com/slava77, @eliasronhttps://github.com/eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktfhttps://github.com/ktf you are the release manager for this.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1682#issuecomment-29891954.

[slava77]

Hi Nancy, if the Validation was not supposed to enter, could you please remove it and update this PR (or submit a new one).

Thank you

Slava

[rovere]

-1

ciao @nancymarinelli indeed I see problems w/ your pull request.
For example you define conversionOITrackProducer and conversionIOTrackProducer as InputTags, but in the corresponding cc (https://github.com/nancymarinelli/cmssw/blob/750ecab7eb57a4c1555f721a471b660fbbf0d9b4/Validation/RecoEgamma/plugins/PhotonValidator.cc#L107) you still try to get them as string.

I fear something wrong went in.

I'd second Slava's request and try to pull Validation stuff out if this PR.

Ciao,
Marco.

[slava77]

Nancy,

I understand that everything from this PR is included in #1801 and later.
If so, please close this one.

THanks

Slava

[nancymarinelli]

Hi,
Yes. How do I close it ?

N.

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: slava77 <notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.commailto:reply@reply.github.com>
Date: Tue, 17 Dec 2013 05:43:12 -0800
To: cms-sw/cmssw <cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli <nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Nancymarinelli/nm700 refinements (#1682)

Nancy,

I understand that everything from this PR is included in #1801#1801 and later.
If so, please close this one.

THanks

Slava

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1682#issuecomment-30751236.

[slava77]

On 12/17/13, 4:23 PM, nancymarinelli wrote:

Hi,
Yes. How do I close it ?

There should be a button "Close"

If you can't find it, we'll ask Giulio

    --slava

N.

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: slava77 <notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw
<reply@reply.github.commailto:reply@reply.github.com>
Date: Tue, 17 Dec 2013 05:43:12 -0800
To: cms-sw/cmssw
<cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli
<nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Nancymarinelli/nm700 refinements (#1682)

Nancy,

I understand that everything from this PR is included in
#1801#1801 and later.
If so, please close this one.

THanks

Slava

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/1682#issuecomment-30751236.

—
Reply to this email directly or view it on GitHub
#1682 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

[nancymarinelli]

The content of this PR was included via another branch into PR 1801

[nancymarinelli]

Just done. I hope it worke.
N.

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: slava77 <notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.commailto:reply@reply.github.com>
Date: Tue, 17 Dec 2013 07:25:38 -0800
To: cms-sw/cmssw <cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli <nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Nancymarinelli/nm700 refinements (#1682)

On 12/17/13, 4:23 PM, nancymarinelli wrote:

Hi,
Yes. How do I close it ?

There should be a button "Close"

If you can't find it, we'll ask Giulio

--slava

N.

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: slava77 <notifications@github.commailto:notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw
<reply@reply.github.commailto:reply@reply.github.commailto:reply@reply.github.com>
Date: Tue, 17 Dec 2013 05:43:12 -0800
To: cms-sw/cmssw
<cmssw@noreply.github.commailto:cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli
<nancy.marinelli@cern.chmailto:nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Nancymarinelli/nm700 refinements (#1682)

Nancy,

I understand that everything from this PR is included in
#1801#1801 and later.
If so, please close this one.

THanks

Slava

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/1682#issuecomment-30751236.

—
Reply to this email directly or view it on GitHub
#1682 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.commailto:slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1682#issuecomment-30759657.