-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EGM - PFPhoton Selection / Particle Based Isolation / New Soft-Electron ID / New Converted Brem Finder / ECAL Regressions for PF-SCs+Electrons+Photons #1801
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X. EGM - PFPhoton Selection / Particle Based Isolation / New Soft-Electron ID / New Converted Brem Finder / ECAL Regressions for PF-SCs+Electrons+Photons It involves the following packages: Validation/RecoEgamma @nclopezo, @danduggan, @rovere, @cmsbuild, @thspeer, @deguio, @slava77, @eliasron can you please review it and eventually sign? Thanks. |
(collapsed 5 commits to one for brevity)
… GT, so temporary) Add hooks to get gedphoton regressions from database in python.
Additionally, implement some comments from previous code review. Update particle based isolation: remove the pair from the map. Stick in just a vector of PFCandidates- only the candidates which needs to be excluded from the isolation sums, make the cone size configurable and fix the value to infinite cone
port of PF-ECAL SCs to new regression calculator add DB source and ES prefer for gedelectron ECAL regressions, fix a crash working on regression common regression calculation framework
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log ----- Begin Fatal Exception 14-Dec-2013 20:46:40 CET----------------------- An exception of category 'BadAlloc' occurred while [0] Constructing the EventProcessor Exception Message: A std::bad_alloc exception was thrown. The job has probably exhausted the virtual memory available to the process. ----- End Fatal Exception ------------------------------------------------- 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log ----- Begin Fatal Exception 14-Dec-2013 20:47:04 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD ----- End Fatal Exception ------------------------------------------------- 1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log ----- Begin Fatal Exception 14-Dec-2013 20:47:10 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT ----- End Fatal Exception ------------------------------------------------- 401.0 step1 runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log 1306.0 step3 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 14-Dec-2013 20:50:05 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15 ----- End Fatal Exception ------------------------------------------------- 4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log ----- Begin Fatal Exception 14-Dec-2013 20:50:24 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT ----- End Fatal Exception ------------------------------------------------- 25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log ----- Begin Fatal Exception 14-Dec-2013 20:58:21 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-14-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
Until the new MVA classifier files are not attached to release (see On 14/12/13 20:58, cmsbuild wrote:
|
ecalWeightsFromDB = cms.bool(True), | ||
# if not from DB. Otherwise, keep empty | ||
ecalRefinedRegressionWeightFiles = cms.vstring(), | ||
combinationWeightsFromDB = cms.bool(True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lindsey,
is that the change you mentioned (together with the label for the combination DB label) ? In that case, you were perfectly right to do it. Thanks
Florian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Florian,
Yes it is, and the changes at the top of the file to get the weights from the DB (until they are in the GT).
-Lindsey
-1 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log ----- Begin Fatal Exception 16-Dec-2013 14:07:34 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT ----- End Fatal Exception ------------------------------------------------- 5.1 step1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log ----- Begin Fatal Exception 16-Dec-2013 14:07:34 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS ----- End Fatal Exception ------------------------------------------------- 401.0 step1 runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log ----- Begin Fatal Exception 16-Dec-2013 14:07:37 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS ----- End Fatal Exception ------------------------------------------------- 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log ----- Begin Fatal Exception 16-Dec-2013 14:07:39 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD ----- End Fatal Exception ------------------------------------------------- 1003.0 step2 runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log ----- Begin Fatal Exception 16-Dec-2013 14:07:48 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM ----- End Fatal Exception ------------------------------------------------- 1306.0 step3 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 16-Dec-2013 14:10:38 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15 ----- End Fatal Exception ------------------------------------------------- 4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log ----- Begin Fatal Exception 16-Dec-2013 14:10:53 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT ----- End Fatal Exception ------------------------------------------------- 25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log ----- Begin Fatal Exception 16-Dec-2013 14:18:40 CET----------------------- An exception of category 'FileInPathError' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PFElecTkProducer label='pfTrackElec' Exception Message: edm::FileInPath unable to find file RecoParticleFlow/PFTracking/data/TMVAClassification_ConvBremFinder_Testetlt20absetalt1_479_BDT.weights.xml anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/src:/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-16-0200/external/slc5_amd64_gcc481/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
@davidlt Can you please test this one manually, it passes all matrix tests for me. There are missing files from CMSDIST that have to be downloaded by hand. |
Hi Linsey, I am afraid you were mentioning the wrong David, I will run them by hand. |
+1 |
@@ -59,7 +61,7 @@ | |||
'keep recoConversions_conversions_*_*', | |||
'keep recoConversions_mustacheConversions_*_*', | |||
'drop *_conversions_uncleanedConversions_*', | |||
'drop *_gedPhotons_valMapPFEgammaCandToPhoton_*', | |||
'drop *_gedPhotonsTmp_valMapPFEgammaCandToPhoton_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the gedPhotonsTmp are not kept (commented out a few lines above), what's the reason to keep gedPhotonsTmp_valMapPFEgammaCandToPhoton ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nancymarinelli Please comment?
As requested in cms-sw/cmssw#1801.
As requested in cms-sw/cmssw#1801.
+1 |
This is before the last fix: regular mode (non-GED) The electron energy error change looks quite significant: is it expected? (the old one has ~the same shape as the regular gsfElectrons) The GED photon et is now above the generated 10GeV (is this the "around threshold" effect?) Gamma 35:
Electron 35 sample QCD 15-3000 sample |
@beaudett Looks like we may have some issue with the calculation of the various uncertainty estimator MVAs at low pT. Could you please have a look at this? |
Hello, what is "reference", "new version" and "new reference" in these plots ? Thanks On 17/12/13 1:56 PM, slava77 wrote:
|
Ah, it is new-minus-reference Ok. Got it. On 17/12/13 2:09 PM, Florian Beaudette wrote:
|
So, is the trackMomentumError was forgotten just in the output electrons, or did it affect other intermediate/derived values (momentum combination etc)? |
Hi, the computation of this quantity is done in a place that I didn't expect and which was no longer "called" in GED mode. More precisely, it is done in a helper class while I would have expected it to be done in the main algo. F. |
my understanding is that this pull request is superseded by #1834. Am I correct? |
Not really, it is more that 1834 is based on this and needs pieces from this one to function properly. |
1 similar comment
@slava77 concerning the shape differences. The new energy error estimates are based on a BDT where the old are based off of some parameterizations. I am not entirely sure they're directly comparable. |
+1 tested 5b92d89 in CMSSW_7_0_X_2013-12-16-0200 Compared to the previous iteration: the momentumError is fixed, even though it doesn't introduce a very significant effect on the combined momentum itself. This should be merged assuming cms-sw/cmsdist#299 is included in the IB |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
RecoUpdates -- EGM - PFPhoton Selection / Particle Based Isolation / New Soft-Electron ID / New Converted Brem Finder / ECAL Regressions for PF-SCs+Electrons+Photons
Skip tests. |
built on top of CMSSW_7_0_0_pre10
This is the last major update to the EGM software for 700 with the aim of bringing it to an 'analysis ready' state for the HPA exercise in 2014.
You will need to manually download the new MVA weight file, for the classifiers, in the following packages:
RecoParticleFlow/PFTracking
RecoEgamma/ElectronIdentification
with the usual
cat download.url | xargs wget
Changes can occur in:
The PR for setting the GED RECO to default will come on another PR, based on top of this one.
There will be a follow up after this PR is merged for the GT update in #1835.
This will just be removing the ESPrefer statements for the PF-SCs, electrons and photons.