HCAL DQM update for 8_4_X

[DryRun]

Some updates for HCAL DQM:

• Inconsistency between emap and RecHits after collapsing resulted in missing channels in ieta-iphi plots. Removed a hard check on the channels, so missing channels should appear.
• Add QIE11 digis (aka HEP17) to DigiTask.
• Remove QIE10Task (redundant with DigiTask, QIE10==HF now) and ZDCTask.
• Fixed crashing hcalcalib (GeometryIdeal --> GeometryRecoDB).

@vkhristenko @deguio

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for CMSSW_8_4_X.

It involves the following packages:

DQM/HcalTasks
DQM/Integration

@cmsbuild, @vanbesien, @dmitrijus can you please review it and eventually sign? Thanks.
@threus, @batinkov, @deguio this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_4_X IBs after it passes the integration tests.

[cmsbuild]

-1

Tested at: b681fc7

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
00227c1
22d4984
9acd960
de15940
9b115ff
face8d4
45d4615
f77247c
b8815bc
2ce390f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17881/18359/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17881/18359/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17881/18359/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
00227c1
22d4984
9acd960
de15940
9b115ff
face8d4
45d4615
f77247c
b8815bc
2ce390f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17881/18359/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17881/18359/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #17881 was updated. @perrotta, @ghellwig, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @slava77, @mmusich, @vanbesien, @mulhearn can you please check and sign again.

[DryRun]

I just committed a fix (c548eb0) for a crash in RecHitTask - removing the requirement that channels be present in the emap led to attempts to fill electronics channel plots with nonexistent electronics channels (i.e. eid==0). I reintroduced the consistency check for these histograms only.

Also, I see that some tests failed with the following error, which doesn't look like a problem with the PR itself:

----- Begin Fatal Exception 13-Mar-2017 12:08:42 CET-----------------------
An exception of category 'FormatIncompatibility' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=MixingModule label='mix'
Exception Message:
The release you are using, "CMSSW_8_4_0_patch2" , predates
a release ("CMSSW_9_0_0_pre4") used in writing the input file, root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_0_0_pre4/RelValMinBias_13/GEN-SIM/90X_mcRun2_asymptotic_v1-v1/10000/80A7D7A4-65EA-E611-9F23-0CC47A4D765E.root.
Forward compatibility cannot be supported.
----- End Fatal Exception -------------------------------------------------

[dmitrijus]

You need to commit this change into development branch, or 91x (master branch). Tests should not fail there.

[DryRun]

OK, thank you, I will do that.

[slava77]

-1

from the context, it looks like updates are only to DQM/HcalTasks/plugins/RecHitTask.cc
and the other signatures are dragged in by an inappropriate merge