Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use presamples and sample variables correctly for HF TP #18170

Closed
wants to merge 1 commit into from

Conversation

matz-e
Copy link
Contributor

@matz-e matz-e commented Apr 3, 2017

Backport of #18169.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_9_0_X.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 3, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18874/console Started: 2017/04/03 16:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

@abdoulline
Copy link

@matz-e
I presume this fix is indispensable for 901 MC production(s)?

@matz-e
Copy link
Contributor Author

matz-e commented Apr 4, 2017

@abdoulline This is more for configuring the TP emulation for the DQM following the recent (pre)sample changes online. If we want to keep MC prod completely in sync than this + adjustment of configuration is needed. But I'm not sure that the online parameters are stable now?

@abdoulline
Copy link

abdoulline commented Apr 4, 2017 via email

@matz-e
Copy link
Contributor Author

matz-e commented Apr 4, 2017

@abdoulline Yes, it should be in sync in the future. Currently, we would have to take care of using different parameters when running on MC and reemulating 2017 data, still.

@davidlange6
Copy link
Contributor

Closing PR. CMSSW_9_0_X development has completed (CMSSW_9_2_X is for data taking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants