-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use presamples and sample variables correctly for HF TP #18170
Conversation
A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_9_0_X. It involves the following packages: SimCalorimetry/HcalTrigPrimAlgos @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@matz-e |
@abdoulline This is more for configuring the TP emulation for the DQM following the recent (pre)sample changes online. If we want to keep MC prod completely in sync than this + adjustment of configuration is needed. But I'm not sure that the online parameters are stable now? |
OK, so it's not indispensible for MC (other than to keep all the
parameters in sync) to deliver correct results at the end, but at some
point in the future we need to bring all in sync?
…On Tue, 4 Apr 2017, Matthias Wolf wrote:
@abdoulline This is more for configuring the TP emulation for the DQM following the
recent (pre)sample changes online. If we want to keep MC prod completely in sync than
this + adjustment of configuration is needed. But I'm not sure that the online
parameters are stable now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02qC0FpD5TAuH_C-sNTH35mJ53Jawks5rsfspgaJpZM4MxMZ4.gif]
|
@abdoulline Yes, it should be in sync in the future. Currently, we would have to take care of using different parameters when running on MC and reemulating 2017 data, still. |
Closing PR. CMSSW_9_0_X development has completed (CMSSW_9_2_X is for data taking) |
Backport of #18169.