-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #18353 to 90X, plus update TP nsamples and adc2fC #18509
Backport #18353 to 90X, plus update TP nsamples and adc2fC #18509
Conversation
…to GeometryRecoDB did it...
A new Pull Request was created by @DryRun (David Yu) for CMSSW_9_0_X. It involves the following packages: DQM/HcalCommon @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
No longer a backport, cannot be merged. |
Pull request #18509 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
Closing PR. CMSSW_9_0_X development has completed (CMSSW_9_2_X is for data taking) |
Backports #18353 to 9_0_2 for online DQM.
For correcting the number of samples in HF TP emulation, I merged the following:
I also changed the adc2fC conversion to use the DB values as in normal reconstruction, rather than a hard-coded lookup table.
These additional two items will be incorporated into the next PR to 9_1_X (coordinate with the TP nsamples PRs).
@christopheralanwest