Correct v4 for mixed 9-10 eta partition geometry

[dildick]

No description provided.

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

Correct v4 for mixed 9-10 eta partition geometry

It involves the following packages:

Geometry/GEMGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

@dildick - I would not mess with geometry scenarios at customization stage. It is better to use a correct --geometry option instead. Which one of the scenarios needs this customization?
Thanks. Yana

[dildick]

This file is to customize the GE11 geometry on top of the 2019 or 2023 scenarios. Otherwise I would have to do a lot of copying to get all prototypes available via the "--geometry" option. I use it mainly for testing purposes anyway. I you prefer not to have this "expert" option, then I'll only keep it in my private CMSSW.

[ianna]

+1

@dildick - as long as it is for pilot geometry test, it's ok. However, a correct scenario will have to be in place when a relval production is requested. As soon as the scenarios are in a GT, this customization will not work.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

[dildick]

Of course, once the geometry is finalized, I'll clean it up (probably after TDR/TP).

[cmsbuild]

Pull request #2258 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

[dildick]

This PR will be closed. Additional RPC updates for Muon Phase-II will be built on top in a new branch.

[ianna]

@dildick - it could be that ME0 is a bit premature here, I think Hcal will overlap with it.

[dildick]

Ok. I'll revert this one, so piet has a clean starting point.

[cmsbuild]

-1
I found an error when building:

SyntaxError: ('invalid syntax', ('src/Geometry/GEMGeometry/python/gemGeometryCustoms.py', 12, 18, 'def custom_GE11_9-10partitions_v1(process):\n'))

gmake[1]: **\* [CompilePython] Error 1
gmake[1]: Leaving directory `/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_6_2_X_SLHC-slc5_amd64_gcc472/CMSSW_6_2_X_SLHC_2014-01-31-0200'
gmake: **\* [src] Error 2
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2258/3/summary.html

[dildick]

@cmsbuild It's fixed. Can you check it?

[cmsbuild]

Pull request #2258 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2258/4/summary.html

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2258/15/summary.html

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (tests are also fine). @andersonjacob, @mark-grimes can you please take care of it?

[mark-grimes]

merge

3300, 4100, 4400, 40001, 50002, 60002, 4502, 4500 and 5001 pass

3400 and 15001 fail in harvesting - known error introduced by #2265
50001 and 60001 fail in step1 - known error introduced by #2236

3400 with combinedCustoms.cust_2019WithGem passes, although expected it to fail as for #2250. Log looks fine, not sure why. gemCustoms must pull in the required changes directly although looking at the diff it doesn't appear to.