Phase2 tracker (BE5D) + extendedPixel up to eta=4

[boudoul]

Files from @atricomi

First attempt to add the extended pixel phase2 tracker geometry (new geometry) in the release.

I'm providing here the recipe (up to GENSIM):
cmsDriver.py FourMuPt_1_200_cfi --conditions auto:upgradePLS3 -n 10 --eventcontent FEVTDEBUG --relval 9000,300 -s GEN,SIM --datatier GEN-SIM --beamspot Gauss --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_phase2_BE5DPixel10D --geometry ExtendedPhase2TkBE5DPixel10D --magField 38T_PostLS1 --fileout file:step1.root

the recipe is not configured in runthematrix at this stage, but it seems that nothing already configured is broken or affected by this new geometry (tested with runTheMatrix.py --what upgrade -l 3300,4400 )

[cmsbuild]

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

Phase2 tracker (BE5D) + extendedPixel up to eta=4

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

The following packages do not have a category, yet:

SLHCUpgradeSimulations/Configuration

@civanch, @Dr15Jones, @vlimant, @ianna, @cerminar, @ktf, @cmsbuild, @franzoni, @nclopezo, @mdhildreth, @Degano, @fabiocos can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[vlimant]

+1

Le 30/01/2014 14:13, cmsbuild a écrit :

A new Pull Request was created by @boudoul https://github.com/boudoul
(boudoul) for CMSSW_6_2_X_SLHC.

Phase2 tracker (BE5D) + extendedPixel up to eta=4

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

The following packages do not have a category, yet:

SLHCUpgradeSimulations/Configuration

@civanch https://github.com/civanch, @Dr15Jones
https://github.com/Dr15Jones, @vlimant https://github.com/vlimant,
@ianna https://github.com/ianna, @cerminar
https://github.com/cerminar, @ktf https://github.com/ktf, @cmsbuild
https://github.com/cmsbuild, @franzoni https://github.com/franzoni,
@nclopezo https://github.com/nclopezo, @mdhildreth
https://github.com/mdhildreth, @Degano https://github.com/degano,
@fabiocos https://github.com/fabiocos can you please review it and
eventually sign? Thanks.
@ghellwig https://github.com/ghellwig, @cerati
https://github.com/cerati, @GiacomoSguazzoni
https://github.com/GiacomoSguazzoni, @rovere
https://github.com/rovere this is something you requested to watch as
well.
You can sign-off by replying to this message having '+1' in the first
line of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@andersonjacob https://github.com/andersonjacob, @mark-grimes
https://github.com/mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

—
Reply to this email directly or view it on GitHub
#2236 (comment).

[mark-grimes]

Verified that it doesn't break any of the other geometries with:
3300,3400,4100,4400,40001,50002,60002,60001,4502,4500,5001,15001,50001
Also tested the GEMs with
3400 and combinedCustoms.cust_2019WithGem

Tried Gaelle's recipe (in the comment above) and got:

%MSG-e HCalGeom:  OscarProducer:g4SimHits@beginRun 31-Jan-2014 16:33:54 CET  Run: 1
HcalDDDSimConstants: cannot get filtered  view for OnlyForHcalSimNumbering not matching any
%MSG
----- Begin Fatal Exception 31-Jan-2014 16:33:54 CET-----------------------
An exception of category 'DDException' occurred while
   [0] Processing run: 1
   [1] Running path 'simulation_step'
   [2] Calling beginRun for module OscarProducer/'g4SimHits'
Exception Message:
HcalDDDSimConstants: cannot match OnlyForHcalSimNumbering to any
----- End Fatal Exception -------------------------------------------------

Since this doesn't break any pre-existing geometries I'm happy to merge and let you sort this out with another patch. @boudoul do you want this in as it is and then fix it later? Odd that the error is in the HCal.

[ianna]

@mark-grimes - either you pick up wrong geometry or the geometry scenario used was not updated. The solution is to update it. Which scenario is used?

[mark-grimes]

Geometry is ExtendedPhase2TkBE5DPixel10D with combinedCustoms.cust_phase2_BE5DPixel10D customisation and auto:upgradePLS3 conditions. I just copied Gaelle's cmsDriver command above verbatim, after building on top of CMSSW_6_2_X_SLHC_2014-01-31-0200.

[ianna]

@mark-grimes - is it based on 2017, 2019 or 2023?

[atricomi]

@mark-grimes I have runned on it wo any problem using
cmsDriver.py FourMuPt_1_200_cfi --conditions auto:upgradePLS3 -n 10 --eventcontent FEVTDEBUG --relval 9000,300 -s GEN,SIM --datatier GEN-SIM --beamspot Gauss --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_phase2_BE5DPixel10D --geometry ExtendedPhase2TkBE5DPixel10D,ExtendedPhase2TkBE5DPixel10DReco --magField 38T_PostLS1 --fileout file:step1.root

Il giorno 31/gen/2014, alle ore 16.58, Mark Grimes ha scritto:

Geometry is ExtendedPhase2TkBE5DPixel10D with combinedCustoms.cust_phase2_BE5DPixel10D customisation and auto:upgradePLS3 conditions. I just copied Gaelle's cmsDriver command above verbatim, after building on top of CMSSW_6_2_X_SLHC_2014-01-31-0200.

—
Reply to this email directly or view it on GitHub.

[ianna]

@mark-grimes - ok, I can see from GT it is 2019 scenario, it means that Hcal needs to be update to PhaseI as in Geometry/CMSCommonData/python/cmsExtendedGeometry2019XML_cfi.py

241a208
>         'Geometry/EcalCommonData/data/ectkcable.xml',
250c217,218
<         'Geometry/HcalCommonData/data/hcalalgo.xml',
---
>         'Geometry/HcalCommonData/data/PhaseI/hcalalgo.xml',
>         'Geometry/HcalCommonData/data/hcalcablealgo.xml',
252c220
<         'Geometry/HcalCommonData/data/hcalendcapalgo.xml',
---
>         'Geometry/HcalCommonData/data/PhaseI/hcalendcapalgo.xml',
254a223,224
>         'Geometry/HcalCommonData/data/PhaseI/hcalSimNumbering.xml', 
>         'Geometry/HcalCommonData/data/PhaseI/hcalRecNumbering.xml', 

[ianna]

@atricomi - Please, try it again with the latest IB: CMSSW_6_2_X_SLHC_2014-01-31-0200

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2236/6/summary.html

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2236/12/summary.html

[mark-grimes]

Checked again on top of #2265 which has just been merged. All the normal tests still run fine (except for a known issue in harvesting for 2 tests). Still can't get Gaelle's test to run (same error) with or without @ianna's suggested changes.

Since nothing existing is broken I'm happy to merge. @atricomi and/or @boudoul do you want this in SLHC7 as it is and fix it later? Time is very short for SLHC7 so there's no time for an iteration of fixes before then.

[boudoul]

Yes , please go ahead, thanks

Le 4 févr. 2014 à 14:04, Mark Grimes a écrit :

Checked again on top of #2265 which has just been merged. All the normal tests still run fine (except for a known issue in harvesting for 2 tests). Still can't get Gaelle's test to run (same error) with or without @ianna's suggested changes.

Since nothing existing is broken I'm happy to merge. @atricomi and/or @boudoul do you want this in SLHC7 as it is and fix it later? Time is very short for SLHC7 so there's no time for an iteration of fixes before then.

—
Reply to this email directly or view it on GitHub.

[mark-grimes]

merge

[davidlange6]

@ianna, all

in PR 2352 I made BE5DPixel10D look like BE5D which does some the problem with GEN-SIM crashing. However - some of the HcalCommonData files in both geometries come from "Phase0" directories, which are naively not the ones we want. Eg, BE5D should be 2019+tracker changes. You might look at revisiting these geometries if SLHC7 is otherwise ok for the HCal now.

On Jan 31, 2014, at 5:04 PM, ianna notifications@github.com wrote:

@mark-grimes - ok, I can see from GT it is 2019 scenario, it means that Hcal needs to be update to PhaseI as in Geometry/CMSCommonData/python/cmsExtendedGeometry2019XML_cfi.py

241a208

    'Geometry/EcalCommonData/data/ectkcable.xml',

250c217,218

< 'Geometry/HcalCommonData/data/hcalalgo.xml',

    'Geometry/HcalCommonData/data/PhaseI/hcalalgo.xml',
    'Geometry/HcalCommonData/data/hcalcablealgo.xml',

252c220

< 'Geometry/HcalCommonData/data/hcalendcapalgo.xml',

    'Geometry/HcalCommonData/data/PhaseI/hcalendcapalgo.xml',

254a223,224
'Geometry/HcalCommonData/data/PhaseI/hcalSimNumbering.xml',
'Geometry/HcalCommonData/data/PhaseI/hcalRecNumbering.xml',

—
Reply to this email directly or view it on GitHub.