Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gem rpc phase ii geometry integration #2276

Merged
merged 75 commits into from
Feb 5, 2014
Merged

Gem rpc phase ii geometry integration #2276

merged 75 commits into from
Feb 5, 2014

Conversation

pietverwilligen
Copy link
Contributor

Inclusion of RPC RE3/1 and RE4/1 chambers up to eta < 2.4 with 192 strips.
Integration of GEM and RPC geometries in Extended2023 geometry scenario.
Build on top of latest ib: CMSSW_6_2_X_SLHC_2014-02-03-0200

ianna and others added 30 commits December 20, 2013 16:29
@ianna
RPC upscope
a634bb9
@ianna
Merged RPC-upscope from repository ianna
1fb2ac8
@ianna
Correct geometry and numbering.
63c47b6
@ianna
Extend RE3/1 to 2.4 Eta
d2dc8eb
@ianna
Add RPC 2.4 Eta upscope scenario
539c0e2
@ianna
Extend RE4/1 to 2.4 eta
502b793
@ianna
Use current shielding
e4873ec
@ianna
Include extended RR4 chambers
6d55469
@pietverwilligen
Modified to incorporate RPC Chamber with more than 3 eta partition, b…
ba6fec7 
…ack-ward compatible
@pietverwilligen
Added G3,G4,G5,H3,H4,H5 rolls for Eta 2p4 upgrade
b0f8d00
@pietverwilligen
Simplified loading of RPC Endcap Sensitive Volumes such that upgrades…
1e599ef 
… are included automatically
@pietverwilligen
uncommented RE3/1 (REG) and RE4/1 (REH) volumes
802bc1f
@pietverwilligen
more debug info
89ce2ec
@pietverwilligen
loading right Extended2023RPCEtaUpscope geometry
42f2a08
@pietverwilligen
updated config for RPCEtaUpgradeReco_cff file
a3db836
@pietverwilligen
adapted to new geometry
98fc051
@pietverwilligen
first commit
5ccee74
@lgray
add weights to products, start on update LHE event products
39305e3
@lgray
correctly parsing weights information in events
2dd165d
@lgray
first working version
75f8522
@lgray
first actually working version :-)
e8a3262
@lgray
validated
4c8b170
@lgray
remove double usage of boost
455f41c
@lgray
add originalXWGTUP() to LHEEvent and LHEEventProduct so that reweight…
405c8dd 
…ing is less cumbersome
@pietverwilligen
modified for 5 rolls in RE3/1 and RE4/1
024d445
@pietverwilligen
changed RE3/1 and RE4/1 from 64 to 256 strips
7907e28
@pietverwilligen
configuration file for RE3/1 and RE4/1 with 256 strips
ef17c7b
@pietverwilligen
configuration file for 256 strips in RE3/1 and RE4/1
4a63ac6
@pietverwilligen
configuration file for 256 strips in RE3/1 and RE4/1
722e76b
@cmsbuild
Merge pull request cms-sw#2101 from lgray/store_lhe_original_xwgtup_6…
3bbde01 
…2X_SLHC

add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition
pietverwilligen and others added 20 commits February 1, 2014 19:00
@pietverwilligen
deleted files
b9667b0
@pietverwilligen
added RE3/1 and RE4/1 with 192 strips
8d011af
@pietverwilligen
improved version
aa1dfc9
@pietverwilligen
to test Extended2023 geometry
5185513
@pietverwilligen
add debug stdcouts
62fd7db
@pietverwilligen
forgot some RE4 volumes to port from working 192 strips branch
49f23ea
@pietverwilligen
forgot some RE4 volumes to port from working 192 strips branch
e6f83e6
@pietverwilligen
forgot some RE4 volumes to port from working 192 strips branch
0019370
@pietverwilligen
forgot some RE4 volumes to port from working 192 strips branch
821134e
@pietverwilligen
forgot some RE4 volumes to port from working 192 strips branch
03462fa
@pietverwilligen
forgot some RE4 volumes to port from working 192 strips branch
6bc7b7e
@pietverwilligen
add debug info
f53fe2f
@pietverwilligen
improved
d282535
Merged GE11-geometry-customs from repository dildick
f961887
Merged RPC-Upgrade-Eta-2p4-192-Strips from repository pietverwilligen
b06bd72 
Conflicts:
	Configuration/Geometry/python/GeometryExtended2023_cff.py
	Geometry/CMSCommonData/python/cmsExtendedGeometry2023XML_cfi.py
	Geometry/MuonSimData/data/PhaseII/muonSens.xml
	Geometry/RPCGeometry/test/testRPCGeometry_cfg.py
Merged GEM-RPC-geometry-customs from repository pietverwilligen
1b45b43 
Conflicts:
	Geometry/RPCGeometry/test/testRPCGeometry_cfg.py
	Geometry/RPCGeometryBuilder/data/PhaseII/RPCSpecs.xml
merge Geometry/MuonCommonData/data/upscope/2.4Eta/muonNumbering.xml
9826650
@pietverwilligen
xml syntacs fix
6b3f96d
@pietverwilligen
load extended2023 geom
0f1e67b
@pietverwilligen
load extended2023 geom
190a59c
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

A new Pull Request was created by @pietverwilligen for CMSSW_6_2_X_SLHC.

Gem rpc phase ii geometry integration

It involves the following packages:

Configuration/Geometry
DQM/RPCMonitorDigi
DataFormats/MuonDetId
Geometry/CMSCommonData
Geometry/GEMGeometry
Geometry/MuonCommonData
Geometry/MuonSimData
Geometry/RPCGeometry
Geometry/RPCGeometryBuilder
SimMuon/RPCDigitizer

@civanch, @ojeda, @danduggan, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rovere, @deguio, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@pietverwilligen
Copy link
Contributor Author

Hi All

This Pull request comprises quite a bit of work on the RE3/1 and RE4/1
simulation and digitization. Reco will come soon (probably ready for
SLHC8). Is it possible to include it in SLHC7. I understood the release has
been postponed a bit for HCAL. Is it possible to get this change in for
Muon? We would be greatful.
Thanks a lot
Kind regards
Piet Verwilligen

On Mon, Feb 3, 2014 at 6:12 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @pietverwilligenhttps://github.com/pietverwilligenfor CMSSW_6_2_X_SLHC.

Gem rpc phase ii geometry integration

It involves the following packages:

Configuration/Geometry
DQM/RPCMonitorDigi
DataFormats/MuonDetId
Geometry/CMSCommonData
Geometry/GEMGeometry
Geometry/MuonCommonData
Geometry/MuonSimData
Geometry/RPCGeometry
Geometry/RPCGeometryBuilder
SimMuon/RPCDigitizer

@civanch https://github.com/civanch, @ojeda https://github.com/ojeda,
@danduggan https://github.com/danduggan, @iannahttps://github.com/ianna,
@mdhildreth https://github.com/mdhildreth, @cmsbuildhttps://github.com/cmsbuild,
@Dr15Jones https://github.com/Dr15Jones, @roverehttps://github.com/rovere,
@deguio https://github.com/deguio, @Degano https://github.com/degano,
@ktf https://github.com/ktf, @nclopezo https://github.com/nclopezocan you please review it and eventually sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@andersonjacob https://github.com/andersonjacob, @mark-grimeshttps://github.com/mark-grimesyou are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

Reply to this email directly or view it on GitHubhttps://github.com//pull/2276#issuecomment-33976540
.

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 377 67 03 132

@dildick
Copy link
Contributor

dildick commented Feb 3, 2014

@pietverwilligen, can you remove the 3 ".xml~" files?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2276/17/summary.html

@ianna
Copy link
Contributor

ianna commented Feb 4, 2014

+1

@mark-grimes
Copy link

merge

3300, 4100, 4400, 40001, 50002, 60002, 4502, 4500 and 5001 pass

3400 and 15001 fail in harvesting - known error introduced by #2265 (test uses incorrect customisation for step 4).
50001 and 60001 fail in step1 - known error introduced by #2236 (FastSim only).

3400 with combinedCustoms.cust_2019WithGem seg faults in harvesting with the same stack trace as for #2250. Known issue (test uses incorrect customisation for step 4).

cmsbuild added a commit that referenced this pull request Feb 5, 2014
@cmsbuild
Merge pull request #2276 from pietverwilligen/GEM-RPC-PhaseII-geometr…
085a91d 
…y-integration

Gem rpc phase ii geometry integration
@cmsbuild cmsbuild merged commit 085a91d into cms-sw:CMSSW_6_2_X_SLHC Feb 5, 2014
@pietverwilligen pietverwilligen deleted the GEM-RPC-PhaseII-geometry-integration branch October 21, 2014 10:40
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
@aledegano
Merge pull request cms-sw#2276 from degano/frontier_81XStable
8fb4e02 
Upgrade frontier client to v 2.8.19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-pending dqm-pending generators-pending geometry-approved orp-pending pending-signatures simulation-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_6_2_X_SLHC
Development

Successfully merging this pull request may close these issues.
8 participants
@pietverwilligen @cmsbuild @dildick @ianna @mark-grimes @lgray @aledegano @ktf