Run3-gex14 Remove some overlap in Run3 geometry #31574

bsunanda · 2020-09-24T21:12:10Z

PR description:

Remove some overlaps coming in the PPS part of Run3 geometry

PR validation:

Tested using the G4 overlap tool

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-09-24T21:12:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-24T21:18:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31574/18607

This PR adds an extra 36KB to repository

cmsbuild · 2020-09-24T21:18:36Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/VeryForwardData
SimG4Core/PrintGeomInfo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @forthommel, @jan-kaspar, @rovere, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2020-09-24T22:02:42Z

@cmsbuild Please test

cmsbuild · 2020-09-24T22:03:05Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9559/console Started: 2020/09/25 00:47

vargasa · 2020-09-24T22:21:55Z

Configuration/Geometry/g4n.log

@@ -0,0 +1,7 @@
+----- Begin Fatal Exception 24-Sep-2020 19:32:24 CEST-----------------------


Can this file be removed?

Sorry - I missed it. I did a "git add ." without realizing the consequence

Could the two commits be squashed together to avoid the file appearing in the git history (even if it is small)?

cmsbuild · 2020-09-24T23:11:43Z

The code-checks are being triggered in jenkins.

bsunanda · 2020-09-24T23:12:15Z

@cmsbuild Please test

cmsbuild · 2020-09-24T23:17:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31574/18611

This PR adds an extra 36KB to repository
Found files with invalid states:
- Configuration/Geometry/g4n.log:
  - Added: 2a60de8
  - Deleted: 6efd235

cmsbuild · 2020-09-25T02:02:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-482fa4/9559/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-09-25T06:51:11Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-482fa4/9561/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-09-25T22:21:20Z

+1

kpedro88 · 2020-09-25T22:24:33Z

+upgrade

civanch · 2020-09-26T13:57:39Z

+1

cmsbuild · 2020-09-26T13:58:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-09-26T14:40:29Z

+1

makortel · 2020-09-28T01:05:16Z

Apparently this PR caused two unit tests in DetectorDescription/DDCMS to fail

==== Let's go to #45
>>> 5 level: PixelBarrelSuppBox is a Box
Full path to it is world_volume/OCMS_1/CMSE_1/Tracker_1/PixelBarrel_1/PixelBarrelSuppBox_2
    copy Nos: 1, 1, 1, 1, 2, 
    levels  : 0, 0, 6, 2, 2, 
F

DDFilteredView.goto.cppunit.cc:68:Assertion
Test name: testDDFilteredViewGoTo::checkFilteredView
assertion failed
- Expression: it == refPos_[i++]

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0

---> test testDD4hepFilteredViewGoTo had ERRORS

and

Go to #45
5 level: PixelBarrelSuppBox is a Box
Full path to it is world_volume/OCMS_1/CMSE_1/Tracker_1/PixelBarrel_1/PixelBarrelSuppBox_2
2, 1, 1, 1, 1, 
0, 0, 6, 2, 2, 
0, 0, 6, F

DDFilteredView.level.cppunit.cc:93:Assertion
Test name: testDDFilteredViewLevel::checkFilteredView
assertion failed
- Expression: it == refPos_[count++]

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0

---> test testDD4hepFilteredViewLevel had ERRORS

For more information see http://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_X_2020-09-27-0000/unitTestLogs/DetectorDescription/DDCMS

bsunanda · 2020-09-28T03:13:40Z

@markotel This PR has nothing to do with that failure. PixelBarrelSuppBox belongs to Tracker and this PR deals with PPS related xml's> One needs to investigate the failures independently

silviodonato · 2020-09-28T07:13:52Z

@bsunanda these errors appeared since CMSSW_11_2_X_2020-09-27-0000 and this PR is the only PR merged between CMSSW_11_2_X_2020-09-26-1100 and CMSSW_11_2_X_2020-09-27-0000, so they seem related to this PR. Anyway I will double check this manually.

silviodonato · 2020-09-28T08:37:39Z

@bsunanda
I tried in CMSSW_11_2_X_2020-09-27-2300
Baseline: error in testDD4hepFilteredViewLevel and testDD4hepFilteredViewGoTo
I tried again after having copied
cp Geometry/CMSCommonData/data/extend/v2/cmsextent.xml Geometry/CMSCommonData/data/extend/v3/cmsextent.xml
and I got

---> test testDD4hepFilteredViewLevel succeeded
---> test testDD4hepFilteredViewGoTo succeeded

silviodonato · 2020-09-28T09:56:26Z

@bsunanda I investigated a bit the issue.
You can compare the log from CMSSW_11_2_X_2020-09-26-1100 and from CMSSW_11_2_X_2020-09-27-0000.
In particular there is a change in the level numbers
from (CMSSW_11_2_X_2020-09-26-1100)

#1: >>> 1 level: OCMS is a Box
Full path to it is world_volume/OCMS_1
    copy Nos: 1, 
    levels  : 0, 
#2: >>> 2 level: CMSE is a Box
Full path to it is world_volume/OCMS_1/CMSE_1
    copy Nos: 1, 1, 
    levels  : 0, 0, 
#3: >>> 3 level: CMStoZDC is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 0, 
#4: >>> 3 level: CMStoZDC is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_2
    copy Nos: 1, 1, 2, 
    levels  : 0, 0, 1, 
#5: >>> 3 level: ZDCtoFP420 is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP420_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 2, 
#6: >>> 3 level: ZDCtoFP420 is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP420_2
    copy Nos: 1, 1, 2, 
    levels  : 0, 0, 3, 
#7: >>> 3 level: Tracker is a Polycone
Full path to it is world_volume/OCMS_1/CMSE_1/Tracker_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 4,

to (CMSSW_11_2_X_2020-09-27-0000)

#1: >>> 1 level: OCMS is a Box
Full path to it is world_volume/OCMS_1
    copy Nos: 1, 
    levels  : 0, 
#2: >>> 2 level: CMSE is a Box
Full path to it is world_volume/OCMS_1/CMSE_1
    copy Nos: 1, 1, 
    levels  : 0, 0, 
#3: >>> 3 level: CMStoZDC is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 0, 
#4: >>> 3 level: CMStoZDC is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_2
    copy Nos: 1, 1, 2, 
    levels  : 0, 0, 1, 
#5: >>> 3 level: ZDCtoFP4201 is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4201_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 2, 
#6: >>> 3 level: ZDCtoFP4201 is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4201_2
    copy Nos: 1, 1, 2, 
    levels  : 0, 0, 3, 
#7: >>> 3 level: ZDCtoFP4202 is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4202_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 4, 
#8: >>> 3 level: ZDCtoFP4202 is a Tube
Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4202_2
    copy Nos: 1, 1, 2, 
    levels  : 0, 0, 5, 
#9: >>> 3 level: Tracker is a Polycone
Full path to it is world_volume/OCMS_1/CMSE_1/Tracker_1
    copy Nos: 1, 1, 1, 
    levels  : 0, 0, 6,

If we remove two out of ZDCtoFP4201_1, ZDCtoFP4201_2, ZDCtoFP4202_1, ZDCtoFP4202_2, the level numbers do not change (eg. levels : 0, 0, 4, for Tracker) and then the tests pass.
I'm not sure if this means there is an error in the geometry or in the unit test.

bsunanda · 2020-09-28T10:29:31Z

This is surely error in the unit test. It cannot test on number of children in CMSE or on absolute position of a given child in the mother. It is better to inhibit the unit test for the time being till a concrete test is found.

…

________________________________ From: Silvio Donato [notifications@github.com] Sent: 28 September 2020 11:56 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-gex14 Remove some overlap in Run3 geometry (#31574) @bsunanda<https://github.com/bsunanda> I investigated a bit the issue. You can compare the log from CMSSW_11_2_X_2020-09-26-1100<https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/slc7_amd64_gcc820/CMSSW_11_2_X_2020-09-26-1100/unitTestLogs/DetectorDescription/DDCMS> and from CMSSW_11_2_X_2020-09-27-0000<https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/slc7_amd64_gcc820/CMSSW_11_2_X_2020-09-27-0000/unitTestLogs/DetectorDescription/DDCMS>. In particular there is a change in the level numbers from (CMSSW_11_2_X_2020-09-26-1100) #1: >>> 1 level: OCMS is a Box Full path to it is world_volume/OCMS_1 copy Nos: 1, levels : 0, #2: >>> 2 level: CMSE is a Box Full path to it is world_volume/OCMS_1/CMSE_1 copy Nos: 1, 1, levels : 0, 0, #3: >>> 3 level: CMStoZDC is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_1 copy Nos: 1, 1, 1, levels : 0, 0, 0, #4: >>> 3 level: CMStoZDC is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_2 copy Nos: 1, 1, 2, levels : 0, 0, 1, #5: >>> 3 level: ZDCtoFP420 is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP420_1 copy Nos: 1, 1, 1, levels : 0, 0, 2, #6: >>> 3 level: ZDCtoFP420 is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP420_2 copy Nos: 1, 1, 2, levels : 0, 0, 3, #7: >>> 3 level: Tracker is a Polycone Full path to it is world_volume/OCMS_1/CMSE_1/Tracker_1 copy Nos: 1, 1, 1, levels : 0, 0, 4, to (CMSSW_11_2_X_2020-09-27-0000) #1: >>> 1 level: OCMS is a Box Full path to it is world_volume/OCMS_1 copy Nos: 1, levels : 0, #2: >>> 2 level: CMSE is a Box Full path to it is world_volume/OCMS_1/CMSE_1 copy Nos: 1, 1, levels : 0, 0, #3: >>> 3 level: CMStoZDC is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_1 copy Nos: 1, 1, 1, levels : 0, 0, 0, #4: >>> 3 level: CMStoZDC is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/CMStoZDC_2 copy Nos: 1, 1, 2, levels : 0, 0, 1, #5: >>> 3 level: ZDCtoFP4201 is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4201_1 copy Nos: 1, 1, 1, levels : 0, 0, 2, #6: >>> 3 level: ZDCtoFP4201 is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4201_2 copy Nos: 1, 1, 2, levels : 0, 0, 3, #7: >>> 3 level: ZDCtoFP4202 is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4202_1 copy Nos: 1, 1, 1, levels : 0, 0, 4, #8: >>> 3 level: ZDCtoFP4202 is a Tube Full path to it is world_volume/OCMS_1/CMSE_1/ZDCtoFP4202_2 copy Nos: 1, 1, 2, levels : 0, 0, 5, #9: >>> 3 level: Tracker is a Polycone Full path to it is world_volume/OCMS_1/CMSE_1/Tracker_1 copy Nos: 1, 1, 1, levels : 0, 0, 6, If we remove two out of ZDCtoFP4201_1, ZDCtoFP4201_2, ZDCtoFP4202_1, ZDCtoFP4202_2, the level numbers do not change (eg. levels : 0, 0, 4, for Tracker) and then the tests pass. I'm not sure if this means there is an error in the geometry or in the unit test. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31574 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOTO46BSDUUUHKG25DLSIBMVXANCNFSM4RYY4UWQ>.

bsunanda · 2020-09-28T13:57:45Z

It is better to remove levels from the unit test - can you let me know the name of the unit test?

makortel · 2020-09-28T14:01:26Z

@ianna already made a fix in #31605.

Remove some overlap in Run3 geometry

2a60de8

cmsbuild added this to the CMSSW_11_2_X milestone Sep 24, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Sep 24, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 24, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 24, 2020

vargasa reviewed Sep 24, 2020

View reviewed changes

Unwanted file removed

6efd235

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Sep 24, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 25, 2020

cmsbuild mentioned this pull request Sep 25, 2020

DD4hep: Introduces functional Tracker navigation + DetIds building #31573

Merged

cmsbuild added geometry-approved and removed geometry-pending labels Sep 25, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 25, 2020

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Sep 26, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 26, 2020

cmsbuild merged commit 051d43f into cms-sw:master Sep 26, 2020

qliphy mentioned this pull request Sep 28, 2020

Error in testDD4hepFilteredViewLevel and testDD4hepFilteredViewGoTo #31604

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex14 Remove some overlap in Run3 geometry #31574

Run3-gex14 Remove some overlap in Run3 geometry #31574

bsunanda commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

bsunanda commented Sep 24, 2020

cmsbuild commented Sep 24, 2020 •

edited

Loading

vargasa Sep 24, 2020

bsunanda Sep 24, 2020

makortel Sep 24, 2020

cmsbuild commented Sep 24, 2020

bsunanda commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

cvuosalo commented Sep 25, 2020

kpedro88 commented Sep 25, 2020

civanch commented Sep 26, 2020

cmsbuild commented Sep 26, 2020

qliphy commented Sep 26, 2020

makortel commented Sep 28, 2020

bsunanda commented Sep 28, 2020

silviodonato commented Sep 28, 2020

silviodonato commented Sep 28, 2020

silviodonato commented Sep 28, 2020

bsunanda commented Sep 28, 2020 via email

bsunanda commented Sep 28, 2020

makortel commented Sep 28, 2020

		@@ -0,0 +1,7 @@
		----- Begin Fatal Exception 24-Sep-2020 19:32:24 CEST-----------------------

Run3-gex14 Remove some overlap in Run3 geometry #31574

Run3-gex14 Remove some overlap in Run3 geometry #31574

Conversation

bsunanda commented Sep 24, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

bsunanda commented Sep 24, 2020

cmsbuild commented Sep 24, 2020 • edited Loading

vargasa Sep 24, 2020

Choose a reason for hiding this comment

bsunanda Sep 24, 2020

Choose a reason for hiding this comment

makortel Sep 24, 2020

Choose a reason for hiding this comment

cmsbuild commented Sep 24, 2020

bsunanda commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

cvuosalo commented Sep 25, 2020

kpedro88 commented Sep 25, 2020

civanch commented Sep 26, 2020

cmsbuild commented Sep 26, 2020

qliphy commented Sep 26, 2020

makortel commented Sep 28, 2020

bsunanda commented Sep 28, 2020

silviodonato commented Sep 28, 2020

silviodonato commented Sep 28, 2020

silviodonato commented Sep 28, 2020

bsunanda commented Sep 28, 2020 via email

bsunanda commented Sep 28, 2020

makortel commented Sep 28, 2020

cmsbuild commented Sep 24, 2020 •

edited

Loading