[DD4hep] Fix Navigation Reference Point #31605

ianna · 2020-09-28T12:56:40Z

PR description:

Addresses #31604

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-09-28T12:57:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-28T13:02:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31605/18661

This PR adds an extra 12KB to repository

cmsbuild · 2020-09-28T13:02:41Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ianna · 2020-09-28T13:08:20Z

please test

cmsbuild · 2020-09-28T13:08:45Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-28-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9618/console Started: 2020/09/28 15:31

cmsbuild · 2020-09-28T14:47:42Z

+1
Tested at: 966b8dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f4326/9618/summary.html
CMSSW: CMSSW_11_2_X_2020-09-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-28T14:47:45Z

Comparison job queued.

ianna · 2020-09-28T15:01:44Z

+1

cmsbuild · 2020-09-28T15:02:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-09-28T16:17:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f4326/9618/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-09-28T17:36:33Z

+1
Tested at: 966b8dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36d0af/9627/summary.html
CMSSW: CMSSW_11_2_X_2020-09-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-28T17:36:37Z

Comparison job queued.

cmsbuild · 2020-09-28T19:01:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36d0af/9627/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

silviodonato · 2020-09-29T06:59:33Z

+1

cmsbuild · 2020-09-29T10:26:12Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #31610

CMSSW_11_2_X_2020-09-28-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9643/console Started: 2020/09/29 14:13

cmsbuild · 2020-09-29T13:26:08Z

+1
Tested at: 966b8dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-131bc9/9643/summary.html
CMSSW: CMSSW_11_2_X_2020-09-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-29T13:26:11Z

Comparison job queued.

cmsbuild · 2020-09-29T15:19:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-131bc9/9643/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

adjast navigation reference

966b8dc

cmsbuild added this to the CMSSW_11_2_X milestone Sep 28, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Sep 28, 2020

ianna mentioned this pull request Sep 28, 2020

Error in testDD4hepFilteredViewLevel and testDD4hepFilteredViewGoTo #31604

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2020

makortel mentioned this pull request Sep 28, 2020

Run3-gex14 Remove some overlap in Run3 geometry #31574

Merged

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Sep 28, 2020

ianna mentioned this pull request Sep 28, 2020

[DD4hep] Filtered View is not a Shape #31603

Closed

cmsbuild added the tests-started label Sep 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Sep 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 29, 2020

cmsbuild merged commit ccd916d into cms-sw:master Sep 29, 2020

ianna mentioned this pull request Sep 29, 2020

[DD4hep] Remove ".*:" aka "any" Namespace Definition from a Part Selector #31610

Merged

cmsbuild added tests-started and removed tests-approved labels Sep 29, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Sep 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] Fix Navigation Reference Point #31605

[DD4hep] Fix Navigation Reference Point #31605

ianna commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

ianna commented Sep 28, 2020

cmsbuild commented Sep 28, 2020 •

edited

Loading

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

ianna commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

silviodonato commented Sep 29, 2020

cmsbuild commented Sep 29, 2020 •

edited

Loading

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

[DD4hep] Fix Navigation Reference Point #31605

[DD4hep] Fix Navigation Reference Point #31605

Conversation

ianna commented Sep 28, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

ianna commented Sep 28, 2020

cmsbuild commented Sep 28, 2020 • edited Loading

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

ianna commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

silviodonato commented Sep 29, 2020

cmsbuild commented Sep 29, 2020 • edited Loading

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 28, 2020 •

edited

Loading

cmsbuild commented Sep 29, 2020 •

edited

Loading