L1T: KBMTF update to coarse eta (backport) #33946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @rekovic for CMSSW_11_3_X. It involves the following packages: L1Trigger/L1TMuonBarrel @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
backport of #33846 |
|
please test |
|
@rekovic I think we have to run the test with cms-data/L1Trigger-L1TMuon#21(we need a backport of cms-sw/cmsdist#6940 ) |
|
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ...
|
|
please test with cms-data/L1Trigger-L1TMuon#21 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b47552/15594/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
@rekovic @cecilecaillol As mentioned by @silviodonato #33946 (comment) we need a backport of cms-sw/cmsdist#6940 for IB/CMSSW_11_3_X/master |
|
+1 |
|
Hi @qliphy , this PR is way beyond any deadline for the MWGR, how critical is it ? |
|
@boudoul Without this PR there will be differences in data-emul comparisons in DQM for Barrel, but this is not critical. |
|
@boudoul We will stay with 11_3_1_patch1 for MWGR#4, not to include this PR. |
|
ok thanks for your answers - But we may be careful when merging in the data release so close to data taking.. In case there is a need for a last minute urgent bug fix, then you will built a release which will also contain all the extra (not critical) PRs increasing the risk of failures and time to eventually fix...I would personally suggest to schedule the merge of this kind of PRs (e.g PRs arriving after deadlines but not critical, not urgent) after the critical moments which are between the final tests and the actual start of data taking with the given release. |
|
@boudoul Thanks! Your comments are well taken:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated KBMTF coarse eta assignments in the bmtf/omtf regions. New LUTs can be found in the external data
L1Trigger/L1TMuon/data/bmtf_luts/kalmanLUTs_v302.root,
which is already merged in CMSSW_11_3_X.
The only change of this PR is the config, pointing to the new LUT.