Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos

[bsunanda]

PR description:

Use of ESGetToken in RecoLocalCalo/HcalRecAlgos

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35234/25195

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35234/25195/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35234/25195/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35234/25197

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• CalibMuon/DTCalibration (alca)
• GeneratorInterface/SherpaInterface (generators)
• RecoLocalCalo/HcalRecAlgos (reconstruction)
• SimTracker/SiPhase2Digitizer (upgrade, simulation)
• Validation/DTRecHits (dqm)

@SiewYan, @andrius-k, @Saptaparna, @alberto-sanchez, @civanch, @yuanchao, @ErnestaP, @ahmad3213, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @mdhildreth, @AdrianoDee, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @mkirsano, @kmaeshima, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@thuer, @apsallid, @mkirsano, @battibass, @rchatter, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @argiro, @abdoulline, @simonepigazzini, @tocheng, @thomreis, @alberto-sanchez, @mmusich, @VinInn, @threus, @dgulhan, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[abdoulline]

Is it supposed to pick up so many "extra" commits?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dae06/18510/summary.html
COMMIT: 86bc68d
CMSSW: CMSSW_12_1_X_2021-09-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35234/18510/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000967
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

Is it supposed to pick up so many "extra" commits?

I think @bsunanda rebased too much. Can you please try to do

git rebase -i HEAD~1
git push my-cmssw +HEAD:Run3-hcx320

?
I think that will just keep the last (and only relevant) commit from here

[cmsbuild]

Pull request #35234 was updated. @SiewYan, @andrius-k, @Saptaparna, @alberto-sanchez, @civanch, @yuanchao, @ErnestaP, @ahmad3213, @agrohsje, @GurpreetSinghChahal, @mdhildreth, @AdrianoDee, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @mkirsano, @kmaeshima, @srimanob, @tvami, @rvenditti can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35234/25200

• This PR adds an extra 16KB to repository

[bsunanda]

Close in favor of #35241 (this PR got mixed up with wrong history)

[tvami]

-alca

• PR was closed