Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241

bsunanda · 2021-09-12T19:45:07Z

PR description:

Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234)

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

bsunanda · 2021-09-12T19:46:34Z

@cmsbuild Please test

tvami · 2021-09-12T19:50:15Z

RecoLocalCalo/HcalRecAlgos/test/HcalSevLvlAnalyzer.cc

 #ifdef THIS_IS_AN_EVENTSETUP_EXAMPLE
-  ESHandle<SetupData> pSetup;
-  iSetup.get<SetupRecord>().get(pSetup);
+  auto pSetup = &iSetup.getData(tokSet_);
 #endif


Now that the event setup happens with the getData method, I believe these lines are not needed anymore

tvami · 2021-09-12T19:50:22Z

RecoLocalCalo/HcalRecAlgos/test/HcalSevLvlAnalyzer.cc

+#ifdef THIS_IS_AN_EVENTSETUP_EXAMPLE
+      totkSet_(esConsumes()),
+#endif


Now that the event setup happens with the getData method, I believe these lines are not needed anymore

tvami · 2021-09-12T19:50:30Z

RecoLocalCalo/HcalRecAlgos/test/HcalSevLvlAnalyzer.cc

+#ifdef THIS_IS_AN_EVENTSETUP_EXAMPLE
+  const edm::ESGetToken<SetupData, SetupRecord> totkSet_;
+#endif


Now that the event setup happens with the getData method, I believe these lines are not needed anymore

cmsbuild · 2021-09-12T19:54:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35241/25211

This PR adds an extra 12KB to repository

cmsbuild · 2021-09-12T19:54:54Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos (reconstruction)

@jpata, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @apsallid, @thomreis, @simonepigazzini, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-09-12T21:00:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35241/25212

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35241/25212/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35241/25212/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-09-13T00:53:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35241/25213

This PR adds an extra 12KB to repository

cmsbuild · 2021-09-13T00:54:20Z

Pull request #35241 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

abdoulline · 2021-09-13T04:45:49Z

For the attention of @igv4321

jpata · 2021-09-13T14:48:01Z

@cmsbuild please test

cmsbuild · 2021-09-13T17:45:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4030a5/18556/summary.html
COMMIT: cfaf1ba
CMSSW: CMSSW_12_1_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35241/18556/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000973
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jpata · 2021-09-14T12:30:27Z

+reconstruction

for cfaf1ba
technical, minimal in reco (the changes in /test/ were not reviewed in detail)
no changes expected/observed

cmsbuild · 2021-09-14T12:30:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-14T14:52:50Z

+1

Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing cms-sw#35234)

a90d27c

cmsbuild added this to the CMSSW_12_1_X milestone Sep 12, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 12, 2021

bsunanda mentioned this pull request Sep 12, 2021

Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos #35234

Closed

cmsbuild added tests-started and removed tests-pending labels Sep 12, 2021

tvami reviewed Sep 12, 2021

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 12, 2021

Get rid of commented code

a1db46b

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Sep 12, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 12, 2021

Code check

cfaf1ba

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 13, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 13, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 13, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Sep 14, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 14, 2021

cmsbuild merged commit 6697b2e into cms-sw:master Sep 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241

Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241

bsunanda commented Sep 12, 2021

bsunanda commented Sep 12, 2021

tvami Sep 12, 2021

bsunanda Sep 12, 2021

tvami Sep 12, 2021

bsunanda Sep 12, 2021

tvami Sep 12, 2021

bsunanda Sep 12, 2021

cmsbuild commented Sep 12, 2021

cmsbuild commented Sep 12, 2021

cmsbuild commented Sep 12, 2021

cmsbuild commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

abdoulline commented Sep 13, 2021

jpata commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

jpata commented Sep 14, 2021

cmsbuild commented Sep 14, 2021

perrotta commented Sep 14, 2021

Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241

Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241

Conversation

bsunanda commented Sep 12, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

bsunanda commented Sep 12, 2021

tvami Sep 12, 2021

Choose a reason for hiding this comment

bsunanda Sep 12, 2021

Choose a reason for hiding this comment

tvami Sep 12, 2021

Choose a reason for hiding this comment

bsunanda Sep 12, 2021

Choose a reason for hiding this comment

tvami Sep 12, 2021

Choose a reason for hiding this comment

bsunanda Sep 12, 2021

Choose a reason for hiding this comment

cmsbuild commented Sep 12, 2021

cmsbuild commented Sep 12, 2021

cmsbuild commented Sep 12, 2021

cmsbuild commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

abdoulline commented Sep 13, 2021

jpata commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

Comparison Summary

jpata commented Sep 14, 2021

cmsbuild commented Sep 14, 2021

perrotta commented Sep 14, 2021