modernize CalibTracker/SiStripDCS

[mmusich]

PR description:

Modernize CalibTracker/SiStripDCS:

• merge headers with plugin implementation
• transformed legacy EDAnalyzers into edm::one::EDAnalyzers
• add fillDescriptions methods

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35284/25286

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripDCS (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

• I have no comments after visual inspection of the code changes

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bb69/18633/summary.html
COMMIT: 2b5170b
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35284/18633/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @thomreis ECAL esConsumes migration of remaining file in RecoMET #35179
• @yuanchao Remove unused headers for RECO & SIM packages #35167
• @bsunanda Run3-alca199 Split HOCalibAnalyzer.cc to take out the post analysis part in separate macros #35240
• @mmusich modernize SiStripDetInfoFileWriter #35265
• @Dr15Jones Added esConsumes to HBHERecHitProducerGPU #35228
• @Dr15Jones Change current path in cmsExternalGenerator not cmsRun #35253
• @thomreis ECAL esConsumes migration of CalibCalorimetry packages #35077
• @bsunanda Run3-hcx320 Use of ESGetToken in RecoLocalCalo/HcalRecAlgos (replacing #35234) #35241
• @guitargeek Clean unused dependencies from BuildFiles #35215
• @Dr15Jones Added esConsumes calls to code in RecoLocalMuon #35184
• @mmusich fix undefined behavior in MultiTrackValidator #35086
• @mmusich Alignment/OfflineValidation improvements from CRUZET'21 data analysis #35266
• @Dr15Jones Finish esConsumes migration for L1TMuonBarrelTrackProducer #35095

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bb69/18633/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bb69/18633/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000799
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• jenkins comparison failures are in the msg logger, otherwise everything is ok

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@mmusich why not simply removing FilterTrackerOn.h (which now contains only an empty line)?

[mmusich]

why not simply removing FilterTrackerOn.h (which now contains only an empty line)?

No reason, git history got somehow messed up.

[perrotta]

why not simply removing FilterTrackerOn.h (which now contains only an empty line)?

No reason, git history got somehow messed up.

Can you please remove it, then?

[mmusich]

Can you please remove it, then?

Didn't I already :) ?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35284/25334

• This PR adds an extra 24KB to repository

[mmusich]

@cmsbuild, please test

[cmsbuild]

Pull request #35284 was updated. @yuanchao, @malbouis, @tvami, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bb69/18679/summary.html
COMMIT: ca1d049
CMSSW: CMSSW_12_1_X_2021-09-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35284/18679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000805
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1