Run3-alca199 Split HOCalibAnalyzer.cc to take out the post analysis part in separate macros

[bsunanda]

PR description:

Split HOCalibAnalyzer.cc to take out the post analysis part in separate macros. The changes for HO is done in consultation with the author of the code (Gobinda Majumder)

PR validation:

Tested with private configurations

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25206

ERROR: Build errors found during clang-tidy run.

Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc:89:27: error: constexpr variable 'elosfact' must be initialized by a constant expression [clang-diagnostic-error]
  static constexpr double elosfact =  (14.9+0.96*fabs(log(8*2.8))+0.033*8*(1.0-pow(8,-0.33)));
                          ^
Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc:89:55: note: non-constexpr function 'log' cannot be used in a constant expression
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25207

• This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25207/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25207/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25207/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25207/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25208

• This PR adds an extra 76KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)
• Calibration/HcalCalibAlgos (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25209

• This PR adds an extra 56KB to repository

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35240/25243

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #35240 was updated. @yuanchao, @malbouis, @tvami, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a8337/18575/summary.html
COMMIT: 479661d
CMSSW: CMSSW_12_1_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35240/18575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• There is a huge number of lines modified/added. They mostly refer to macros, and to the HOCalibAnalyzer which is only called inside a test script

[perrotta]

@bsunanda apparently this PR is causing the following build error in the slc7_amd64_gcc10 IBs:

/data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/gcc/10.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)':
  HOCalibAnalyzer.cc:(.text+0x598d): undefined reference to `HOCalibAnalyzer::nphimx'
 /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/gcc/10.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)':
  HOCalibAnalyzer.cc:(.text+0x739d): undefined reference to `HOCalibAnalyzer::nphimx'
 collect2: error: ld returned 1 exit status
  gmake: *** [tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/libCalibrationHcalCalibAlgosPlugins.so] Error 1

It looks strange to me (why undefined reference to `HOCalibAnalyzer::nphimx'? It should be there,,,).
Can you please have a look?

[bsunanda]

I am canging const to constexpr for the variable. I do not see the error in gcc9 build. I tried this with gcc10 and see no issues. I am making a new PR as bug fix

…

________________________________ From: Andrea Perrotta ***@***.*** Sent: 15 September 2021 07:09 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-alca199 Split HOCalibAnalyzer.cc to take out the post analysis part in separate macros (#35240) @bsunanda<https://github.com/bsunanda> apparently this PR is causing the following build error in the slc7_amd64_gcc10 IBs<https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc10/CMSSW_12_1_X_2021-09-14-2300/Calibration/HcalCalibAlgos>: /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/gcc/10.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)': HOCalibAnalyzer.cc:(.text+0x598d): undefined reference to `HOCalibAnalyzer::nphimx' /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/gcc/10.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/HOCalibAnalyzer.cc.o: in function `HOCalibAnalyzer::HOCalibAnalyzer(edm::ParameterSet const&)': HOCalibAnalyzer.cc:(.text+0x739d): undefined reference to `HOCalibAnalyzer::nphimx' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc10/src/Calibration/HcalCalibAlgos/plugins/CalibrationHcalCalibAlgosPlugins/libCalibrationHcalCalibAlgosPlugins.so] Error 1 It looks strange to me (why undefined reference to `HOCalibAnalyzer::nphimx'? It should be there,,,). Can you please have a look? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35240 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOUHLUKWTZV2NG5B6XLUCATBNANCNFSM5D4EWKHQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.