Update fmt to 8.0.1 #7309

iarspider · 2021-09-15T09:11:29Z

No description provided.

iarspider · 2021-09-15T09:11:38Z

please test

cmsbuild · 2021-09-15T09:11:48Z

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @iarspider, @mrodozov can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2021-09-15T11:49:04Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18618/summary.html
COMMIT: 9036a2c
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7309/18618/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw remove unused data package Geometry-TrackerCommonData #7306

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18618/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18618/git-merge-result

Build

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/Geometry/HcalCommonData/src/HcalParametersFromDD.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/Geometry/HcalCommonData/src/HcalSimParametersFromDD.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/Geometry/HcalCommonData/src/HcalSimulationConstants.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/Geometry/HcalCommonData/src/HcalTopologyMode.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/Geometry/HcalCommonData/src/HcalDDDRecConstants.cc: In member function 'std::vector HcalDDDRecConstants::getEtaBins(const int&) const':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/Geometry/HcalCommonData/src/HcalDDDRecConstants.cc:83:72: error: no matching function for call to 'find(std::vector::iterator, std::vector::iterator, int)'
   83 |           if (std::find(phiSp.begin(), phiSp.end(), (zside * phi.first)) == phiSp.end()) {
      |                                                                        ^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/bits/locale_facets.h:48,
                 from /cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/bits/basic_ios.h:37,
                 from /cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/ios:44,

iarspider · 2021-09-15T13:28:53Z

please test with cmssw#35286

smuzaffar · 2021-09-15T13:35:27Z

@iarspider , please use full repo name e.g cms-sw/cmssw#35286

iarspider · 2021-09-15T13:41:41Z

please test with cms-sw/cmssw#35286

cmsbuild · 2021-09-15T18:54:15Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18628/summary.html
COMMIT: 9036a2c
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7309/18628/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18628/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18628/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CalibTracker/SiPixelTools/plugins/SiPixelErrorsDigisToCalibDigis.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CalibTracker/SiPixelTools/plugins/SiPixelFedFillerWordEventNumber.cc
>> Building  edm plugin tmp/slc7_amd64_gcc900/src/CalibTracker/SiPixelTools/plugins/CalibTrackerSiPixelToolsPlugin/libCalibTrackerSiPixelToolsPlugin.so
Leaving library rule at src/CalibTracker/SiPixelTools/plugins
@@@@ Running edmWriteConfigs for CalibTrackerSiPixelToolsPlugin
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/tmp/slc7_amd64_gcc900/src/CalibTracker/SiPixelTools/plugins/CalibTrackerSiPixelToolsPlugin/libCalibTrackerSiPixelToolsPlugin.so because libfmt.so.7: cannot open shared object file: No such file or directory

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelQuality.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelQualityProbabilities.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelTemplateDBObject.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelVCal.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/SiPixelObjects/src/CondFormatsSiPixelObjects/a/Serialization.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CondFormats/SiPixelObjects/src/SiPixelVCal.cc:46:8: error: no member named 'transform' in namespace 'std'
  std::transform(m_vcal.begin(),
  ~~~~~^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/CondFormats/SiPixelObjects/src/SiPixelVCal.cc:57:8: error: no member named 'transform' in namespace 'std'
  std::transform(m_vcal.begin(),
  ~~~~~^

iarspider · 2021-09-15T19:30:52Z

@smuzaffar do you know how this can be fixed:

@@@@ Running edmWriteConfigs for CalibTrackerSiPixelToolsPlugin
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/tmp/slc7_amd64_gcc900/src/CalibTracker/SiPixelTools/plugins/CalibTrackerSiPixelToolsPlugin/libCalibTrackerSiPixelToolsPlugin.so because libfmt.so.7: cannot open shared object file: No such file or directory

libCalibTrackerSiPixelToolsPlugin.so was linked with old libfmt?

smuzaffar · 2021-09-15T20:22:57Z

first try to fix the build errors

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/L1Trigger/L1TMuonOverlap/src/GhostBuster.cc: In member function 'virtual std::vector<AlgoMuon> GhostBuster::select(std::vector<AlgoMuon>, int)':
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/L1Trigger/L1TMuonOverlap/src/GhostBuster.cc:16:8: error: 'sort' is not a member of 'std'; did you mean 'sqrt'?
    16 |   std::sort(refHitCands.rbegin(), refHitCands.rend());
      |        ^~~~
      |        sqrt
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/L1Trigger/L1TMuonOverlap/src/GoldenPattern.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/L1Trigger/L1TMuonOverlap/src/GhostBusterPreferRefDt.cc: In member function 'virtual std::vector<AlgoMuon> GhostBusterPreferRefDt::select(std::vector<AlgoMuon>, int)':
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/L1Trigger/L1TMuonOverlap/src/GhostBusterPreferRefDt.cc:43:8: error: 'sort' is not a member of 'std'; did you mean 'sqrt'?
    43 |   std::sort(muonsIN.rbegin(), muonsIN.rend(), customLess);
      |        ^~~~
      |        sqrt
  gmake: *** [tmp/slc7_amd64_gcc900/src/L1Trigger/L1TMuonOverlap/src/L1TriggerL1TMuonOverlap/GhostBuster.cc.o] Error 1

smuzaffar · 2021-09-16T09:49:30Z

please test
hopefully now bot will deploy the cmssw under /cvmfs/cms-ci.cern.ch even if there are build errors

smuzaffar · 2021-09-16T11:24:17Z

please test with cms-sw/cmssw#35286

cmsbuild · 2021-09-16T16:38:09Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18657/summary.html
COMMIT: 9036a2c
CMSSW: CMSSW_12_1_X_2021-09-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7309/18657/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CalibTracker/SiPixelTools/plugins/SiPixelErrorsDigisToCalibDigis.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CalibTracker/SiPixelTools/plugins/SiPixelFedFillerWordEventNumber.cc
>> Building  edm plugin tmp/slc7_amd64_gcc900/src/CalibTracker/SiPixelTools/plugins/CalibTrackerSiPixelToolsPlugin/libCalibTrackerSiPixelToolsPlugin.so
Leaving library rule at src/CalibTracker/SiPixelTools/plugins
@@@@ Running edmWriteConfigs for CalibTrackerSiPixelToolsPlugin
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/tmp/slc7_amd64_gcc900/src/CalibTracker/SiPixelTools/plugins/CalibTrackerSiPixelToolsPlugin/libCalibTrackerSiPixelToolsPlugin.so because libfmt.so.7: cannot open shared object file: No such file or directory

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelPedestals.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelPerformanceSummary.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelQuality.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelQualityProbabilities.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/T_EventSetup_SiPixelTemplateDBObject.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/SiPixelVCal.cc:46:8: error: no member named 'transform' in namespace 'std'
  std::transform(m_vcal.begin(),
  ~~~~~^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-16-1100/src/CondFormats/SiPixelObjects/src/SiPixelVCal.cc:57:8: error: no member named 'transform' in namespace 'std'
  std::transform(m_vcal.begin(),
  ~~~~~^

smuzaffar · 2021-09-16T16:49:51Z

@iarspider , /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7309/18657/install.sh should be available soon ( it has been publish on cvmfs but will take 10-15 mins before it is visible)

iarspider · 2021-09-17T15:51:23Z

please test with cms-sw/cmssw#35286

cmsbuild · 2021-09-18T08:56:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18713/summary.html
COMMIT: 9036a2c
CMSSW: CMSSW_12_1_X_2021-09-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7309/18713/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update DD4Hep 12_1 to specific commit #7313

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18713/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18713/git-merge-result

Found compilation warnings

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1305 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000833
DQMHistoTests: Total failures: 3682
DQMHistoTests: Total nulls: 20
DQMHistoTests: Total successes: 2997109
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 45.699 KiB( 38 files compared)
DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

Add missing includes (companion commit for cms-sw/cmsdist#7309)

smuzaffar · 2021-09-22T07:21:27Z

please test

cmsbuild · 2021-09-22T14:07:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dc010/18819/summary.html
COMMIT: 9036a2c
CMSSW: CMSSW_12_1_X_2021-09-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7309/18819/install.sh to create a dev area with all the needed externals and cmssw changes.

Found compilation warnings

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3211080
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3211046
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

Update fmt to 8.0.1

9036a2c

cmsbuild added externals-pending orp-pending pending-signatures tests-started labels Sep 15, 2021

cmsbuild added tests-rejected and removed tests-started labels Sep 15, 2021

cmsbuild added requires-external tests-started tests-rejected and removed tests-rejected tests-started labels Sep 15, 2021

cmsbuild added tests-started and removed requires-external tests-rejected labels Sep 16, 2021

cmsbuild added requires-external tests-rejected and removed tests-started labels Sep 16, 2021

cmsbuild added tests-started and removed tests-rejected labels Sep 17, 2021

iarspider mentioned this pull request Sep 18, 2021

Add missing includes (companion commit for cms-sw/cmsdist#7309) cms-sw/cmssw#35286

Merged

cmsbuild added tests-approved and removed tests-started labels Sep 18, 2021

cmsbuild added a commit to cms-sw/cmssw that referenced this pull request Sep 21, 2021

Merge pull request #35286 from iarspider/patch-1

87fa9df

Add missing includes (companion commit for cms-sw/cmsdist#7309)

cmsbuild added tests-started and removed requires-external tests-approved labels Sep 22, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 22, 2021

iarspider merged commit 6d9932e into IB/CMSSW_12_1_X/master Sep 22, 2021

iarspider deleted the update_fmt branch September 22, 2021 14:26

smuzaffar restored the update_fmt branch September 22, 2021 15:43

smuzaffar deleted the update_fmt branch September 22, 2021 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fmt to 8.0.1 #7309

Update fmt to 8.0.1 #7309

iarspider commented Sep 15, 2021

iarspider commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

iarspider commented Sep 15, 2021

smuzaffar commented Sep 15, 2021

iarspider commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

iarspider commented Sep 15, 2021

smuzaffar commented Sep 15, 2021

smuzaffar commented Sep 16, 2021

smuzaffar commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

smuzaffar commented Sep 16, 2021

iarspider commented Sep 17, 2021

cmsbuild commented Sep 18, 2021

smuzaffar commented Sep 22, 2021

cmsbuild commented Sep 22, 2021

Update fmt to 8.0.1 #7309

Update fmt to 8.0.1 #7309

Conversation

iarspider commented Sep 15, 2021

iarspider commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

Build

iarspider commented Sep 15, 2021

smuzaffar commented Sep 15, 2021

iarspider commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

Build

Clang Build

iarspider commented Sep 15, 2021

smuzaffar commented Sep 15, 2021

smuzaffar commented Sep 16, 2021

smuzaffar commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

Build

Clang Build

smuzaffar commented Sep 16, 2021

iarspider commented Sep 17, 2021

cmsbuild commented Sep 18, 2021

Comparison Summary

smuzaffar commented Sep 22, 2021

cmsbuild commented Sep 22, 2021

Comparison Summary